Hi all,

I'm looking at a error related to the parameterized-trigger [1] where the 
SVNRevision is not passed to the child configurations of a matrix build.
Looking at the code for the Matrix configuration it seems that there is 
only the possibility of passing a ParameterAction to it [2] when starting 
the child configurations by the ExecutionStrategy [3].

>From looking at a few other errors in this area there are other actions 
that should be passed to the child builds, 
CauseAction,
EnvInjectAction, 
SVNRevisionAction

The EnvInject(lib) plugin and the Cause run condition plugins, use a 
workaround to get the parent or rootbuild when getting the action they 
require, 
but really all of the different plugins that use actions such as these from 
the Job properties, or other equilivent Extention points, should not have 
to do this.

I would propose adding all actions from parent build to the all of the 
configurations, 
but are there any issues doing this?  
I.e. actions should not be passed on.(MatrixSubsetAction in 
parameterized-trigger)

So should there be an interface that actions implement to indicate that 
they are passed from the parent to the configurations?
that the Matrix configuration can use to filter the actions passed to it.

Or are there any better suggestions?


Chris,


[1] https://issues.jenkins-ci.org/browse/JENKINS-14619
[2] 
https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/matrix/MatrixConfiguration.java#L358
[3] 
https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/matrix/DefaultMatrixExecutionStrategyImpl.java#L200

Reply via email to