done as https://github.com/jenkinsci/jenkins/commit/c14c7619c6157f7bb1006635483e44fe0964852b
feel free to amend to only require CREATE, not DELETE 2012/8/15 domi <[email protected]> > actually I was thinking about the same a couple days ago to > …I would go for the CONFIGURE and CREATE only, because the job already > exists, and the user only wants to rename it - which at the end will create > a new workspace directory on the slave. > Domi > > On 13.08.2012, at 01:39, nicolas de loof <[email protected]> wrote: > > > Hi, > > > > looking at hudson.model.Job#doDoRename, I notice > > // rename is essentially delete followed by a create > > checkPermission(CREATE); > > checkPermission(DELETE); > > > > > > I wonder a user that can't create job but has all other permissions on > job, including CONFIGURE, can't choose a name for his job. > > Would it make sense to check CONFIGURE permission on rename, not CREATE > + DELETE, or maybe a combination of them : > > if (!hasPermision(CONFIGURE)) { > > checkPermission(CREATE); > > checkPermission(DELETE); > > } > >
