Next CVS plugin release. -original message- Subject: RE: CVS Plugin Changeset Date Parse Exception From: Ben Castellucci <[email protected]> Date: 24/08/2012 23:14
Thanks Michael. Just a clarification: next Jenkins release or next CVS Plugin release? If next Jenkins release then what are the chances of stuffing in into an LTS? Thanks again! Ben On Aug 24, 2012 5:53 PM, "Michael Clarke" <[email protected]> wrote: > This looks like a refactoring error. Date formats were previously held in > an array in CvsChangeLogHelper but when Kohsuke split the toFile into > CvsChangeLogSet the wrong date format seems to have been copied across from > the ones available in the array. > > This has already been fixed in master so will be in the next release. > > Thanks, > Michael > > -original message- > Subject: CVS Plugin Changeset Date Parse Exception > From: Ben Castellucci <[email protected]> > Date: 24/08/2012 20:16 > > Greetings. > > In the same vein as [1], [2] and [3], but slightly different. No changes > ever show up for any jobs and I am seeing the following exceptions: > > java.lang.RuntimeException: Change date could not be parsed > ... > Caused by: java.text.ParseException: Unparseable date: "2012/08/24 > 17:11:48" > ... > > In the changelog.xml I see this: > > ... > <changeDate>2012/08/24 17:11:48</changeDate> > ... > > In the older CVS plugin source [4] I see this: > > ... > private static final DateFormat CHANGE_DATE_FORMATTER = new > SimpleDateFormat( > "yyyy-MM-dd HH:mm:ss"); > ... > public void setChangeDateString(final String changeDate) { > synchronized (CHANGE_DATE_FORMATTER) { > Calendar calendar = Calendar.getInstance(); > try { > > calendar.setTime(CHANGE_DATE_FORMATTER.parse(changeDate)); > } catch (ParseException ex) { > throw new RuntimeException( > "Change date could not be parsed", > ex); > } > this.changeDate = calendar; > } > } > > If I go into a particular changelog.xml and change the date format like so: > > <changeDate>2012-08-24 17:11:48</changeDate> > > Then exactly those changes on that build get parsed properly and show as > expected. > > CVS Plugin version is 2.5 and has never been any other version (i.e., all > changelog.xml files have been created with that version). > Jenkins version is 1.447.2. > > Any thoughts, anyone, as to why the plugin is writing the <changeDate> with > one format and then expecting to read it later in another? > > [1]: https://issues.jenkins-ci.org/browse/JENKINS-12573 > [2]: https://issues.jenkins-ci.org/browse/JENKINS-13017 > [3]: https://issues.jenkins-ci.org/browse/JENKINS-12586 > [4]: https://github.com/jenkinsci/cvs-plugin/pull/5/files > >
