My concern is that several plugins use the user property to get the email information about a user, or even to set it. My concern is things will start to go AWOL if someone disables or removes the Mailer plugin from their setup. I am going through pain right now trying to remove dependencies on Mailer from email-ext for this very reason. If you have email-ext, I don't think you need Mailer (especially since the main stuff that email-ext was using Mailer for is now in JenkinsLocationConfiguration), but there are still things that I think should be in core and attached directly to a user instead of relying on a plugin for them.
On Tue, Jan 15, 2013 at 11:31 AM, Jesse Glick <jgl...@cloudbees.com> wrote: > On 01/14/2013 11:54 PM, Slide wrote: > >> Now that the Mailer is outside the core, I think that the User class >> should have an email field (or a list of emails or something). Mail address >> resolution should >> probably be moved back into the core as well. >> > > Perhaps, assuming you can figure out the compatibility issues. The hack in > HudsonPrivateSecurityRealm.**createAccount is pretty ugly, though this > could be addressed directly by adding a simple extension point in core for > initializing the email address of a User, which mailer-plugin would > implement. I guess the question is what was intended to be accomplished by > splitting off mailer-plugin and will that still be accomplished if we have > to move a bunch of code back into core, leaving only the actual > task/action/command in the plugin? > -- Website: http://earl-of-code.com
