On Thursday, January 24, 2013 5:56:33 PM UTC+1, Jesse Glick wrote: > On 01/24/2013 08:21 AM, [email protected] <javascript:> wrote: > > Revert commit > > I would say revert (bdaf5ea too); at least I do not see a clear > description in #494 as to the original purpose of the change. >
Note that the commit came with other patches and comments in the pull URLs that indicate that * the modified method shouldn't be used for encoding query params (https://github.com/jenkinsci/jenkins/commit/1a42a2f071f87b652f3746f8198cd6fcd6bee33e) * some tests failed (probably fixed in https://github.com/jenkinsci/jenkins/commit/c667523d446614ea70dd8fd10ccdad4d3001f246) The original pull request developer mentions some problem with command line. The only place I know ampersand can be a problem in URLs on the command line is when the URLs are not quoted. But I doubt this would have been the problem. Could it be that the matrix configuration backward compatibility issue is caused by some sort of using the Util.encode() API against the spirit of its new spec ? Jerome
