How do you disable an existing build step with Conditional BuildStep plugin? As far as I can see, you can't move existing steps into it, and not out of it either when it's time to clean up the troubleshooting clutter.
However, comments could be implemented with a regular build step, just have a build step which has a text area field and which doesn't do anything. The problem with that is, it would clutter up the job configuration, unlike having a simple icon in the build step header, next to existing help icon. Ari Hyttinen On 22 May 2013 15:47, Sandell, Robert <[email protected]> wrote: > https://wiki.jenkins-ci.org/display/JENKINS/Conditional+BuildStep+Plugin > > > > > > Robert Sandell > > Software Tools Engineer - SW Environment and Product Configuration > > Sony Mobile Communications > > > > From: [email protected] [mailto:[email protected]] > On Behalf Of RDR > Sent: den 22 maj 2013 13:16 > To: [email protected] > Subject: Re: Comments on build step > > > > "As an extra wish, also being able to disable a build step without deleting > it would be a great feature, when troubleshooting badly behaving jobs" > > To my mind being able to disable individual steps (including post build > steps) would be a great thing to see. Normally when I have a problematic > feature to fix I end up having to: > * disable the job and > * create a new project based on the original > > * Disable e-mail notifications > > * Fix the issue > > * Copy config changes back to the original > > * Delete (or shelve) the new project > > * Enable the original > > > > On 22 May 2013 11:59, Ari Hyttinen <[email protected]> wrote: > > I think commenting build steps is a brilliant idea, obvious really > when you think about it. I mean, how many have looked at a build step > at a job's configuration, and wondered why it's configured that way, > perhaps even why it is there at all, even if it is an old build step > configured by you yourself. Being able to write a comment to any build > step would be great. As an extra wish, also being able to disable a > build step without deleting it would be a great feature, when > troubleshooting badly behaving jobs. > > > Implementation suggestion: > > The obvious place for UI code for comments (and disable toggle) would > be in hetero-list.jelly. It would probably be inside j:if for > hasHeader > (https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/lib/form/hetero-list.jelly#L77). > There could be either a new fixed-name .jelly file > ("hetero-list-header.jelly" maybe), or a new attribute to define how > the list header should be displayed. > > Then a new file > (/core/src/main/resources/lib/hudson/project/hetero-list-header.jelly > maybe) would actually define the UI for build step comments (and > disable toggle). If needed, config-builders.jelly and > config-publishers2.jelly, which use hetero-list, would be modified to > add new attributes. Modifying config-buildWrappers.jelly to also > include this functionality would be great too, as being able to > comment things like VCS configurations would be valuable. > > Another implementation inspiration would be, how helpFile property > (getHelpFile() method) of a descriptor class is now used, except this > would have to be available for all descriptors. > > Comment would probably be normally hidden, just a new icon next > current question mark icon for help. It would show comment text on > hover, and open a text area for editing on click. > > How and by what class the data would actually be stored, I'm not sure. > > Comments? > > PS. It looks like I will not have time to work on this myself, even > though I'd love this feature. But perhaps above will inspire somebody > else to do this... > > > Ari Hyttinen > > > > On 15 May 2013 00:31, Daniel PETISME <[email protected]> wrote: >> Hi guys, >> >> I'm wondering how it would be possible to add comments in Jenkins build >> steps. I know a jobs should be as easiest as possible, however comments >> never hurt anyone. >> >> The need is to be able to comment the build steps (within the build step >> or >> a dedicated comment one). These comments would be outputed during the job >> execution. Of course the comment should not pollute the job UI. >> >> Do someone as this kind of need or already set a similar feature? >> >> Regards >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > > > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > > > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
