Sounds good, except for readability. As a unaware user, I wouldn't understand why there are two maven plugins for 'apparently' the same features. Maybe some wording like Maven builder plugin, and Maven project type plugin would make it clearer. Vincent
2013/7/17 Stephen Connolly <[email protected]>: > I would favour moving the Maven stuff from core out into a maven-core > plugin. My plans will need some of the stuff in core but *none* of the stuff > in the current maven plugin, so I would be against moving the stuff from > core to the current maven plugin. > > > On 17 July 2013 10:51, Vincent Latombe <[email protected]> wrote: >> >> Hello, >> >> On a slightly different but related topic, I was thinking it could be >> worth having a Builder class to supercede hudson.tasks.Maven (in >> core), but to store that builder in the current maven-plugin. That >> would avoid duplicating some logic to the builder sitting in core just >> because it doesn't have access to maven-plugin classes. That would >> allow a 'smarter' Maven buildstep when working with free-style >> projects. >> >> What do you think? >> >> Vincent >> >> >> 2013/7/17 Stephen Connolly <[email protected]>: >> > On 17 July 2013 10:23, Olivier Lamy <[email protected]> wrote: >> >> >> >> Hi Folks, >> >> Due to some non backward compat changes in maven core 3.1.x, this >> >> doesn't work anymore. >> >> Yes I know some of you (at least I know one!) think this need to be >> >> rewrite. >> > >> > >> > (I know one == me) >> > >> > I don't think is needs to be rewritten... I think it needs to be taken >> > out >> > round the back and shot... FreeStyle + Maven Build Step all the way man! >> > >> >> >> >> >> >> BTW I don't have enough time for the moment to fully rewrite this (but >> >> some ideas :-)) >> >> So in order to take care of users, I will work this weekend on the >> >> current plugin to have it working with 3.1.x. >> >> >> >> Cheers, >> >> -- >> >> Olivier Lamy >> >> Ecetera: http://ecetera.com.au >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy >> >> >> >> -- >> >> You received this message because you are subscribed to the Google >> >> Groups >> >> "Jenkins Developers" group. >> >> To unsubscribe from this group and stop receiving emails from it, send >> >> an >> >> email to [email protected]. >> >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> >> >> > >> > -- >> > You received this message because you are subscribed to the Google >> > Groups >> > "Jenkins Developers" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> > an >> > email to [email protected]. >> > For more options, visit https://groups.google.com/groups/opt_out. >> > >> > >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
