Well, I just got back from a long vacation so when I wrote the previous answer I hadn't seen this pull request yet ;) https://github.com/jenkinsci/gerrit-trigger-plugin/pull/60
Robert Sandell Software Tools Engineer - SW Environment and Product Configuration Sony Mobile Communications From: [email protected] [mailto:[email protected]] On Behalf Of Sandell, Robert Sent: den 22 juli 2013 10:10 To: [email protected] Subject: RE: Integrating Gerrit Trigger and Static Analytics Collector The Gerrit Trigger Plugin has an extension point for other plugins to provide additional content to the comments that are sent to Gerrit. I also have plans to add an extension point to let plugins provide line comments as well, it could be useful to see for example findbugs and checkstyle warnings directly in Gerrit. I think Gerrit is also going to provide possibilities for file comments also, so I might throw that in at the same time ;) Robert Sandell Software Tools Engineer - SW Environment and Product Configuration Sony Mobile Communications From: [email protected]<mailto:[email protected]> [mailto:[email protected]] On Behalf Of Baptiste MATHUS Sent: den 21 juli 2013 10:53 To: [email protected]<mailto:[email protected]> Subject: Re: Integrating Gerrit Trigger and Static Analytics Collector Le 15 juil. 2013 11:55, "Ulli Hafner" <[email protected]<mailto:[email protected]>> a écrit : > > >> Hi >> >> I've been developing a small plugin[1] which will submit[2] warnings from >> static analysis plugins to Gerrit [3]. There's a two questions where I'd >> liked to have some comments, proposals or answers: >> >> 1. Is developing a "integrator" plugin a good way to achieve this? This >> functionality could be added to either of these two plugins, but it just >> doesn't feel right. And what about other plugins which would like to post >> comments to Gerrit? Should there be one integrator plugin for each, should >> they just submit straight to Gerrit or something different? Some parts in my >> plugin could be reused in other cases, mainly the logic which finds out the >> build of parent commit. >> > > This looks like something similar to the CI game plug-in: here we also have > some source plug-ins (e.g., static analysis) and another plugin that consumes > the results and posts them on a different page. > > So I think your plug-in should be a stand-alone plug-in that uses e.g. the > analysis-collector plug-in. Then others can add additional dependencies which > will post additional messages to gerrit. +1. I really like the idea of being able to simply push arbitrary comments/marks to gerrit. So I guess the idea of writing a gerrit publisher would be very useful! Cheers -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]<mailto:[email protected]>. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]<mailto:[email protected]>. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
