Hi there,
Sorry for the long delay in responding to the pull request.
I did see your patch and, beyond it being a niche use case (it's not
really clear to me why this is required, aside from attempting to work
around snapshot failures (for me the solution would be to disable
snapshots)), I have some reservations about the pull request but haven't
had time to reply properly so far.
For example, I would really like to avoid adding a new UI option,
especially when it's one which conflicts with an existing option, and
has a rather confusing name (IMO).
Plus the code seems to do the opposite of what the pull request
describes (i.e. the comparison
buildResult.isBetterOrEqualTo(Result.SUCCESS) is made, when surely the
build result should be *worse* than success)?
In any case, deleting every time the build is unsuccessful seems odd,
when probably you really want to delete when it was "not built" (e.g.
due to emulator timeout) or when the build result is FAILURE.
Ideally, if we want to have this option at all, the existing deletion
option would be extended to have a dropdown or checkboxes allowing the
user to choose one-or-more build results upon which the emulator should
be deleted.
Regards,
Chris
On 23/07/13 04:27, Gautam Korlam wrote:
Hi, any updates on this?
On Tuesday, 16 July 2013 23:38:40 UTC-7, Gautam Korlam wrote:
Hi,
I have been trying to get this patch in for quite sometime now.
https://github.com/jenkinsci/android-emulator-plugin/pull/23
<https://github.com/jenkinsci/android-emulator-plugin/pull/23>
It addresses a major issue
(https://issues.jenkins-ci.org/browse/JENKINS-15928
<https://issues.jenkins-ci.org/browse/JENKINS-15928>) on the
android-emulator plugin for jenkins
Its a pretty straightforward fix. I have been working with jenkins
for about 6 months now on a daily basis and I feel comfortable
changing the source at this point.
Just wanted to see if I could get committer access to push my change
in as the pull request is taking very long to go through.
Thanks,
Gautam
--
You received this message because you are subscribed to the Google
Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups "Jenkins
Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
