Damn, I'm somehow messed up my pull requests a bit... sorry for this. Here the tiny fix: https://github.com/jenkinsci/git-plugin/pull/161
Looks like it works fine. Unit tests not affected. On Wednesday, August 7, 2013 2:08:10 PM UTC+7, nicolas de loof wrote: > > sure, and as you seem to have a concrete use-case to suffer this issue > you're feedback is welcome to confirm bug is still present and propose a > fix :) > > > 2013/8/7 Sapone <[email protected] <javascript:>> > >> Indeed, refactoring not about this bug. >> But my point is - if refactoring affects Prune, and Prune not working >> well, so may be it would be good to make it right at once, during >> refactoring. >> >> >> On Wednesday, August 7, 2013 1:50:09 PM UTC+7, nicolas de loof wrote: >> >>> need to test, but anyway this refactoring goal was not to fix >>> JENKINS-18834 <https://issues.jenkins-ci.org/browse/JENKINS-18834>, so >>> maybe need some extra effort >>> >>> >>> 2013/8/7 Sapone <[email protected]> >>> >>> Oh, now I see what happens... Thanks a lot! >>>> But what about fact, that prune should be done before fetching? (see >>>> JIRA bug) >>>> >>>> >>>> On Tuesday, August 6, 2013 6:39:20 PM UTC+7, nicolas de loof wrote: >>>> >>>>> Isn't https://github.com/**jenki**nsci/git-plugin/blob/**refactori** >>>>> ng/src/main/java/**hudson/**plugins/git/extensions/**impl/** >>>>> PruneStaleBranch.java<https://github.com/jenkinsci/git-plugin/blob/refactoring/src/main/java/hudson/plugins/git/extensions/impl/PruneStaleBranch.java>what >>>>> your looking for ? >>>>> >>>>> >>>>> 2013/8/6 Sapone <[email protected]> >>>>> >>>>>> Looks like Prune option is completly removed in refactoring branch. >>>>>> Why? >>>>>> >>>>>> Here the bug in JIRA: >>>>>> https://issues.jenkins-ci.org/****browse/JENKINS-18834<https://issues.jenkins-ci.org/browse/JENKINS-18834> >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Jenkins Developers" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to jenkinsci-de...@**googlegroups.**com. >>>>>> >>>>>> For more options, visit >>>>>> https://groups.google.com/**grou**ps/opt_out<https://groups.google.com/groups/opt_out> >>>>>> . >>>>>> >>>>>> >>>>>> >>>>> >>>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Jenkins Developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to jenkinsci-de...@**googlegroups.com. >>>> For more options, visit >>>> https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out> >>>> . >>>> >>>> >>>> >>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
