>
>
> Your comment about not storing the abstractProject sounds correct to me.
>
> GerritTrigger extend Trigger and Trigger is storing the job also 
(gerritTrigger have its own reference but do not need to).
 
I am looking at how I could fix this without comparing job, here is more 
info on the problem:

-Trigger start gets called when loaded in memory so a gerrit listener is 
created
-Reload configuration happens but Trigger stop is not called (as it is when 
a job configuration change) which would remove the gerrit listener.
-Trigger start gets called and we end up with a second listener.

I could add validation in the gerritTrigger start to make sure we remove 
old listener for the same job name but before I go this way, is the stop 
method supposed to be called when reloading the configurations?


-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to