exactly, in any case the git plugin should be providing a warning to the user when selecting a credential type that may expose the plaintext password... now that may be tricky to establish over form validation... so maybe the short-cut is that if we see user/pass we issue a warning that says unless you enable JGit the user/pass may be discoverable
On 9 October 2013 12:11, Domi <[email protected]> wrote: > But then I think you should inform the user about the fact that the > password will be send in plain text and also end up in the logs. > > Am 09.10.2013 um 10:54 schrieb nicolas de loof <[email protected]>: > > I investigating another solution : > add the username:password dynamically to URL as git commands are executed > by git-client. > > This would be transparent for git-plugin > > > 2013/10/9 Stephen Connolly <[email protected]> > >> can we add a method to git-client that lets us know if a credential type >> is supported by the backing impl? that way we can add a check method to >> give a warning >> >> >> On 9 October 2013 08:23, nicolas de loof <[email protected]>wrote: >> >>> Sure, this will still be supported, but then not managed as credentials >>> (secret) >>> >>> >>> 2013/10/9 David Karlsen <[email protected]> >>> >>>> Ouch. Git plugin v1 supports this by having it in the url. user:pass >>>> 9. okt. 2013 08:43 skrev "nicolas de loof" <[email protected]> >>>> følgende: >>>> >>>> Probably never will support http credentials. No simple way to >>>>> implement it, but some hack to force a gitcredentials property ... >>>>> >>>>> >>>>> 2013/10/8 Stephen Connolly <[email protected]> >>>>> >>>>>> My only concern is GIT cli with user/pass credentials (I think we are >>>>>> doing ssh-agent for key based so that should be ok) >>>>>> >>>>>> Otoh it is no worse than current no credentials support ;-) >>>>>> >>>>>> >>>>>> On Tuesday, 8 October 2013, Domi wrote: >>>>>> >>>>>>> +1 >>>>>>> >>>>>>> Am 08.10.2013 um 21:38 schrieb nicolas de loof < >>>>>>> [email protected]>: >>>>>>> >>>>>>> you've got my +1 >>>>>>> >>>>>>> >>>>>>> 2013/10/8 Kohsuke Kawaguchi <[email protected]> >>>>>>> >>>>>>>> >>>>>>>> Mainly to Nicolas, >>>>>>>> >>>>>>>> Is it time to release Git plugin 2.0? >>>>>>>> >>>>>>>> As you may know, it has been in a branch for some time, and we've >>>>>>>> gone through two rounds of beta testing. There has been no further >>>>>>>> changes >>>>>>>> from 2.0 beta 2. I just went through all the issues marked for git-2.0 >>>>>>>> and >>>>>>>> swept outstanding issues. >>>>>>>> >>>>>>>> One concern was the SCM API plugin evolution, but I think I heard >>>>>>>> Stephen say that it's good from his perspective. >>>>>>>> >>>>>>>> So it looks Git plugin 2.0 is good to go. It'd be nice to have this >>>>>>>> available for JUC! >>>>>>>> >>>>>>>> -- >>>>>>>> Kohsuke Kawaguchi http://kohsuke.org/ >>>>>>>> >>>>>>>> -- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "Jenkins Developers" group. >>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>> send an email to jenkinsci-dev+unsubscribe@**googlegroups.com. >>>>>>>> For more options, visit >>>>>>>> https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out> >>>>>>>> . >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "Jenkins Developers" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to [email protected]. >>>>>>> For more options, visit https://groups.google.com/groups/opt_out. >>>>>>> >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "Jenkins Developers" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to [email protected]. >>>>>>> For more options, visit https://groups.google.com/groups/opt_out. >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Sent from my phone >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Jenkins Developers" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to [email protected]. >>>>>> For more options, visit https://groups.google.com/groups/opt_out. >>>>>> >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Jenkins Developers" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> For more options, visit https://groups.google.com/groups/opt_out. >>>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Jenkins Developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> For more options, visit https://groups.google.com/groups/opt_out. >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/groups/opt_out. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/groups/opt_out. >> > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
