Was there ever a resolution to this? This seems to be breaking something in email-ext on certain the versions of Jenkins mentioned in the original post.
slide On Thu, Aug 1, 2013 at 7:14 AM, Sandell, Robert < [email protected]> wrote: > I took another look at how the bind tag behaved originally, before my > change. And it is actually so that it starts by adding an adjunct tag for > the bind script. > The reason why this has worked in Jenkins before is because the bind > script is included via the adjunct manager already in the header via the > layout tag, so the inclusion of bind.js in place isn't done at that > specific place. > > So I still claim that the simplest workaround would be to add an adjunct > include for json2 as well in proximity to where bind is added, since the > explicit inclusion of bind could be interpreted as a workaround in itself. > > In layout.jelly: > <!-- we include our own prototype.js, so don't let stapler pull in > another. --> > <st:adjunct assumes="org.kohsuke.stapler.framework.prototype.prototype" > includes="org.kohsuke.stapler.bind"/> > <st:adjunct assumes="org.kohsuke.stapler.framework.prototype.prototype" > includes="org.kohsuke.stapler.json2"/> > > > But there could be some hidden behavior still in my change once this is > solved, so its fine by me if my original change is reverted in stapler, I > can keep working with the older versions. > I don't have the Jenkins dev environment fully setup where I am at the > moment, so it would take a while for me to set it up and test the change. > If anyone has it setup and feel they can fix it quicker, then go ahead :) > > > > Robert Sandell > Software Tools Engineer - SW Environment and Product Configuration > Sony Mobile Communications > > > > -----Original Message----- > > From: [email protected] [mailto:jenkinsci- > > [email protected]] On Behalf Of Jesse Glick > > Sent: den 1 augusti 2013 15:12 > > To: [email protected] > > Subject: Re: JENKINS-18641: Changes to Stapler's JavaScript proxy will > > break plugins depending on it > > > > On Thu, Aug 1, 2013 at 7:20 AM, Jan Molak > > <[email protected]> wrote: > > > for the time being, can we please roll this change set back? > > > > I would agree that unless a clearly correct solution can be introduced, > > this should just be rolled back in Stapler, with a new release cut and > > the JENKINS-18641 workaround reverted. There are lots of other changes > > in Stapler since then that fix important bugs we may need to backport > > to 1.509.3, so inclusion of this change would cause mayhem. (Just > > checked the CloudBees Templates plugin as an example since it uses > > <st:bind> inside <script>, and it is indeed broken in 1.527-SNAPSHOT > > when you install jquery.) > > > > Alternately, is there some workaround that can be put in jquery-plugin? > > > > -- > > You received this message because you are subscribed to the Google > > Groups "Jenkins Developers" group. > > To unsubscribe from this group and stop receiving emails from it, send > > an email to [email protected]. > > For more options, visit https://groups.google.com/groups/opt_out. > > > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- Website: http://earl-of-code.com -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
