On Thu, Nov 14, 2013 at 3:13 PM, Marco Miller <[email protected]> wrote: > 4. thread-B recreates the symlink, but that throws our hereby exception, > given 3. (problematic).
Yeah, could happen. > "On some operating systems it may not be possible to remove a file when it > is open and in use by this Java virtual machine or other programs." “Some” operating systems would be built in Redmond, and have mandatory file locks. Do you run one of them? Anyway I doubt you can take out a file lock on a symlink. > would you consider adding handling of that FileAlreadyExistsException, so > createSymlinkJava7 logs it then return true (ok)? Logging a normal condition is pointless, and returning OK if we were trying to _update_ a symlink to a different value would be a bug. Probably the code should look for an existing symlink first, and try to read it, and check that it matches what is already there. And if a FAEE is thrown anyway, maybe retry a couple times to defeat race conditions. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
