If I’m not right, then you only have to return “null” for the Action.getIconFileName() here is an example: https://github.com/jenkinsci/m2release-plugin/blob/master/src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseAction.java#L104 /Domi
On 22.11.2013, at 10:21, scarytom <t.den...@gmail.com> wrote: > > I tried to control whether the icon was shown or not, but failed. Can you > advise how this is done? > > -T > > On Friday, 22 November 2013 05:07:47 UTC, Dominik Bartholdi wrote: > I'm still +1 to enhance the existing > Think of it also from a users point, we have about 600+ plugins and users > have not much help in deciding which plugin he should use, specially as most > of them do about 80% the same as another. > About the menu item, you can control whether an icon is shown or not from > within the plugin, depending on the options one has configured. > Domi > > Am 22.11.2013 um 00:10 schrieb scarytom <t.de...@gmail.com>: > >> Hi Anthony, >> >> I'm sorry if I was a bit harsh about your plug-in. As others have said, >> it's a really good idea. I'm entirely new to Jenkins plug-in development, I >> think I may have mis-read your code: it looked like you registered a new >> AcceleratedBuildNowSorter every time a user triggered an accelerated build, >> and then left them around forever, but I see now that you restore the >> original sorter after the accelerated build has been triggered. >> >> Regarding the merge with the Priority Sorter Plug-in, I actually had a look >> at this before I started a new plug-in. Sadly, it looks like there is a >> fairly major re-write of that plug-in going on at the moment, and I don't >> believe they are anywhere near a release. >> >> On the more general point of "sexier" new plug-ins, I'm not sure what the >> Jenkins community policy on plug-in development is, but in software design, >> generally I'd favour a few small cohesive components (in this case plug-ins) >> each with single responsibility, rather than one giant all-singing, >> all-dancing mega plug-in. Here I see the Priority Sorter Plugin as >> providing the ability to assign priorities to my projects, the Accelerated >> Build Now Plugin as providing the ability to trigger a new build and have it >> run immediately, cancelling builds if necessary, and the Queue Jumper Plugin >> as providing the ability to bump an already-queued build to the top of the >> list so that it gets picked up next. >> >> What are everyone else's thoughts? >> - Tom >> >> >> >> On Thursday, 21 November 2013 21:44:40 UTC, Anthony Dahanne wrote: >> hello, >> I am the author of the accelerated build plugin, and I'd be very grateful if >> you could describe "really nasty, as it leaks queue sorters over time" in a >> Jira; so that I can have a chance to make it better. [1] >> On another topic, when I shared this plugin, I also got asked to merge it >> with the Priority Sorter Plugin - something I did not do yet unfortunately >> [2] >> Sure, it's always sexier to start a new plugin from scratch, but in case >> anybody is interested in spending time thinking about a plugin doing it all >> (via options / scripts/ whatever) I'd be glad to join the effort. >> Regards, >> Anthony >> >> 1: https://issues.jenkins-ci.org/browse/JENKINS/component/18026 >> 2: >> http://jenkins-ci.361315.n4.nabble.com/New-plugin-Accelerated-Build-Now-Plugin-td4675235.html >> >> >> >> On Thu, Nov 21, 2013 at 1:56 PM, scarytom <t.de...@gmail.com> wrote: >> There are a couple of reasons for not enhancing the existing one. >> >> Firstly, there is no sensible way of making the desired change without >> adding a second icon to the menu. I think most people will want one or the >> other behaviour, so this feels like a separate plug-in would be useful. >> Secondly, the way that the existing plug-in is implemented is really nasty, >> as it leaks queue sorters over time. I don't want to take responsibility >> for reworking the existing plug-in, and wouldn't want to install it in its >> current form. >> >> Finally, I'm keen to try and take the queue jumper plug-in in a slightly >> different direction, in that ideally I would add a UI element beside the 'X' >> cancel link for each buildable item in the queue, rather than adding an >> action to the menu. I'm not currently sure whether this kind of plugin is >> possible, so I'd welcome some advice from the experts. >> >> Regards, >> Tom >> >> >> >> >> On Thursday, 21 November 2013 15:46:48 UTC, Kevin Fleming wrote: >> Why not just modify the existing plugin to support the behavior you desire >> as an option? >> >> >> ----- Original Message ----- >> From: jenkin...@googlegroups.com >> To: jenkin...@googlegroups.com >> At: Nov 21 2013 10:44:46 >> Hi, >> >> I would like use the official Jenkins repository to publish a new plugin for >> build queue management that allows a user to bump a build up to the top of >> the queue. This is similar to the "Accelerated Build Now Plugin", but is >> less disruptive in that it doesn't cancel other builds. >> >> Please could you create a jenkinsci/queue-jumper-plugin repo in GitHub. My >> GitHub username is scarytom. >> >> Regards, >> Tom Denley >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to jenkinsci-de...@googlegroups.com. >> >> For more options, visit https://groups.google.com/groups/opt_out. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to jenkinsci-de...@googlegroups.com. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to jenkinsci-de...@googlegroups.com. >> For more options, visit https://groups.google.com/groups/opt_out. > > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to jenkinsci-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
