1. Yes that sounds like a good approach. And at least I can't come up with any other good way of doing it it's probably the best as well ;) 2. All post build actions will be executed before any RunListener.onCompleted are called, so you are safe as long as you use build steps or post build steps. The ordinal is there to help you if your plugin needs to have a RunListener to run before or after the GerritTrigger, for example the Build Failure Analyzer plugin uses this.
Robert Sandell Software Tools Engineer - SW Environment and Product Configuration Sony Mobile Communications > -----Original Message----- > From: [email protected] [mailto:jenkinsci- > [email protected]] On Behalf Of Marcin Zajaczkowski > Sent: den 4 december 2013 19:38 > To: [email protected] > Subject: [gerrit-trigger-plugin] Additional configuration for a non > Describable extension point > > Hello again. Working on an extension using GerritMessageProvider I need > provide user an ability to enable and configure my analysis when needed. > Therefore I have two questions. > > 1. Is it the best approach to create an additional PostBuild (Recorder) > extension which would be added to a build, configured and do all donkey > work and the second Gerrit related extension (extending > GerritMessageProvider) to take the result from an action and > (eventually) translate received objects to the > CommentedFile/LineComment form? > > 2. ToGerritRunListener extension has ordinal number set, but it seems > to do a lot of things in different build stages. What would be the best > way to guarantee that my generic PostBuild action will be executed > before buildCompletedRestCommandJob.createReview -> > gerritMessageProvider.getFileComments? > > Marcin > > -- > You received this message because you are subscribed to the Google > Groups "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
