Here's my try at integrating the security plug-in with the dynamic parameter plug-in.
https://github.com/Seitenbau/sb-jenkins-dynamicparameter/pull/28 - After I integrated the Script Security Plugin many of the existing tests started to fail with NPE. I modified the tests to work with the script approval and updated the Wiki [1] (ps: feel free to massage the text as needed) - Do you think it would be possible and make sense to use an object with some return value in the GroovySandbox too [2]? Like Callable, and we use Void when not returning anything. I added a custom Runnable to store the result of the script execution, since the plug-in uses it to create the dynamic parameters (or was there an easier way?) I had to peek at the code to understand the preapprove and configuring methods and had a quick look at the rest of the code. It all looks nice and works as expected. Kudos and many thanks! Cheers, [1] https://wiki.jenkins-ci.org/pages/diffpages.action?pageId=71436691&originalId=72417559 [2] https://github.com/Seitenbau/sb-jenkins-dynamicparameter/pull/28/files#diff-70f42f03a5626274410da1b61f8726a6R142 Bruno P. Kinoshita http://kinoshita.eti.br http://tupilabs.com >________________________________ > From: Jesse Glick <[email protected]> >To: [email protected] >Sent: Thursday, March 13, 2014 5:41 PM >Subject: Re: Script Security plugin > > >On Thu, Mar 13, 2014 at 4:02 PM, Bruno P. Kinoshita ><[email protected]> wrote: >> I'll have to write a plug-in (or extend the extended choice parameter >> plugin) that will use Groovy. > >There is already one in this area that would benefit from a >script-security integration: > >https://wiki.jenkins-ci.org/display/JENKINS/Jenkins+Dynamic+Parameter+Plug-in > > >-- >You received this message because you are subscribed to the Google Groups >"Jenkins Developers" group. >To unsubscribe from this group and stop receiving emails from it, send an >email to [email protected]. >For more options, visit https://groups.google.com/d/optout. > > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
