On Mon, May 5, 2014 at 10:00 AM, 'ninian_harvey' via Jenkins Developers <[email protected]> wrote: > add the unimplemented 'downloading ZIPs of artifacts' > feature. Has anyone got any pointers on what's left to be done here > (presumably its not as simple as implementing the > CompressingArtifactManager.VF.list() method?)
Probably implementing the list(String) method would suffice. It is a little tricky since DirScanner, which the canonical implementation uses to handle globs, relies on physical File’s; the underlying logic is in Ant’s DirectoryScanner, which also is File-based. You would probably have to reimplement the scan by just iterating ZipEntry’s and using Ant’s SelectorUtils to collect matches. For example, whereas DirectoryScanner might do a recursive directory traversal with some pruning optimizations to find matches for a complex pattern like ‘**/target/TEST-*.xml’, an implementation based on a ZIP file would more readily check all (non-directory) entry paths to see whether they match that pattern or not. Pull requests with test coverage welcome. I prepared the way by extracting the storage into an independent class with a unit test suite. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
