Hey,

I have recently upgraded jenkins and subversion plugin versions, (Jenkins 
1.560, Subversion plugin 2.2)
I have a parameterized job, with an option of List subversion tags. When I 
go to build page, the dropdown shows "Retrieving tags..." for few seconds 
and the it updated the list with all tags. I use this parameter to checkout 
the svn repo. (Previous version fetches the tags before loading the page)
So when I click build before list populates the parameter doesn't contain 
anything it checkout whole repository instead of specific tag. I think it 
should be better if list is not updated and some clicks the build button, 
parameter should contain the default value instead of empty.

I looked at the code Subversion plugin and I think it is required to update 
the code somewhere here -
src/main/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterDefinition.java
 
(Line 129 - 138)
(https://github.com/jenkinsci/subversion-plugin/blob/master/src/main/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterDefinition.java#L129)
Before

  // This method is invoked when the user clicks on the "Build" button of 
Hudon's GUI
  @Override
  public ParameterValue createValue(StaplerRequest req, JSONObject formData) {
    ListSubversionTagsParameterValue value = 
req.bindJSON(ListSubversionTagsParameterValue.class, formData);
    value.setTagsDir(getTagsDir());
    // here, we could have checked for the value of the "tag" attribute of the
    // parameter value, but it's of no use because if we return null the build
    // still goes on...
    return value;
  }


Does anyone face similar problem? Is there any better solution for this?

Thanks,
Gaurav

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to