I think we do have different kinds of docker fixtures.
Some are meant to be generic, which belongs to src, while others are
test specific which belongs to test.
SshdContainer for example is fairly generic and its operation is
encapsulated. GitContainer is somewhat in-between, as a ssh-accessible
writable Git repository is generally useful, and its repository location
on the server is encapsulated in the GitContainer method.
If tests want to define containers local to them, then they should feel
free to do so, and those should better go to test/ directory.
LdapContainer and JiraContainer might belong there already.
People should feel free
On 06/03/2014 06:28 PM, Jesse Glick wrote:
On Tue, Jun 3, 2014 at 6:29 PM, Ulli Hafner <[email protected]> wrote:
Does that mean that you use the same fixture for tests of a different
non-public plugin?
Yes.
your tests would be very fragile if the author of a plugin test changes the
docker container setup or content…
Well if something like GitContainer is changed to behave very
differently, then yes our tests would break, just like any other
incompatible change to jenkinsci/acceptance-test-harness/src/main/
files. I expect any acceptance tests to be extremely fragile to begin
with and this does not seem like the highest risk by far.
--
Kohsuke Kawaguchi | CloudBees, Inc. | http://cloudbees.com/
Try Jenkins Enterprise, our professional version of Jenkins
--
You received this message because you are subscribed to the Google Groups "Jenkins
Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
