I suspect we need a compatibility plugin like this anyway to hide the layout changes (<div> vs <table>) and so on.
On 06/09/2014 03:47 PM, Kohsuke Kawaguchi wrote:
I assume we are only talking about the flashing orb here --- other icons (say the terminal icon) are just fine with them being images, and whatever animations you might require (like fading, etc) can be done with img+css. As for the compatibility issue, what if we produce a plugin that encapsulates the fallback behaviour? For the flashing ball images, the said plugin can define a tag file like: <c:ball icon="${run.iconColor}" size="24" /> ... and the tag can expand to <img> (if running on today's Jenkins) or <div> (if running on tomorrow's Jenkins) On 06/06/2014 10:33 AM, Tom Fennelly wrote:All the icons in Jenkins are hardcoded as images in the Jelly scripts. We were hoping to move away from this (ala Doony) by using CSS + some Javascript (for the animation). Seems like this is not possible to do without getting into screen-scraping hacks <https://github.com/tfennelly/jenkins/blob/orb-orb/core/src/main/resources/lib/layout/orb.js#L80> because the <img>s are used out in plugins too (not just in the core Jenkins code) e.g. the maven plugin. I guess this means we're stuck with using images Vs CSS +Javascript ?
-- Kohsuke Kawaguchi | CloudBees, Inc. | http://cloudbees.com/ Try Jenkins Enterprise, our professional version of Jenkins -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
