I'd prefer that we not add another submitter on the git plugin at this time. I'm not the primary maintainer of the plugin, but I am one of the maintainers. Nicolas or Jesse may well feel differently, and may choose to add you. I defer to their judgment.
The git plugin is widely used, has many complex workflows which it supports, and has relatively few tests to verify those workflows. If you're ready to commit to helping the evolution and improvement of the git plugin, I'd prefer that you use pull requests (for at least a few more submissions) to submit additional tests, or bug fixes supported by tests. After a series of pull requests have passed through, the primary maintainers will then have seen enough of your submissions to be confident that you'll help keep the git plugin in good condition. With luck (and some free time), your pull request can be included in the next week or two. Mark Waite On Fri, Aug 1, 2014 at 2:31 PM, 'Jakob Korherr' via Jenkins Developers < [email protected]> wrote: > Ping. > It would be cool to get commit access to > https://github.com/jenkinsci/git-plugin to be able to merge the pull > request. > > My github id: jakobk > > Thanks, > Jakob > > > On Thu, Jul 31, 2014 at 10:49 AM, Jakob Korherr <[email protected]> > wrote: > >> Hi, >> >> I created a pull request for the git-plugin last week: >> https://github.com/jenkinsci/git-plugin/pull/245 >> >> This pull request fixes JENKINS-22009 and potentially also some related >> issues. I tested the fix locally, and also provided a test case in the pull >> request. The code has also been reviewed by a colleague. >> >> Thus I think the pull request should be merged. I hope you think the same >> way! >> >> Cheers, >> Jakob >> >> >> > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Thanks! Mark Waite -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
