Good to hear. The same issue might be for the project list updater, maybe while you’re in there you could do the same fix for that?
Robert Sandell Software Tools Engineer - SW Environment and Product Configuration Sony Mobile Communications From: [email protected] [mailto:[email protected]] On Behalf Of Ivo Bratanov Sent: den 21 augusti 2014 21:57 To: [email protected] Subject: Re: Gerrit-Trigger "Check non-reviewed patchsets" feature not working I've managed to answer my question, what I found is that this feature is not functional in the latest release of GT, nor in the master. This is because the attempt to add the UnreviewedPatchesListener as a listener to the GerritConnection instance is ignored, causing the check for unreviewed patchsets to never occur. (In GerritServer.java) We've created a fix for this bug and will be contributing it shortly. Ivo Bratanov Jenkins Development Ericsson On Friday, August 15, 2014 3:44:32 PM UTC-4, Ivo Bratanov wrote: Hi, Our team at Ericsson has a need for the "Check non-reviewed patchsets" feature in the Gerrit-Trigger plugin (explained in the issue https://issues.jenkins-ci.org/browse/JENKINS-23871), but I'm having difficulties making the feature work in my environment. I'm currently using the latest release of Gerrit-Trigger, version 2.11.1. Has anyone managed make this feature work? If so, any suggestions would be appreciated. Here is how I'm attempting to use the feature: I've ticked off the "Check non-reviewed patchsets" checkbox in the Jenkins job. The builds are triggering fine while the connection between Jenkins and Gerrit is established, but no attempt is made to look for non-reviewed patchsets in either of the following test cases: a) Shut down Jenkins, create a new patchset in the Gerrit project, and reboot from war file. b) Stop the connection from the server config page, create a new patchset in the Gerrit project, and start connection again. What I've found by running Jenkins in debug mode is that in GerritServer.java, the UnreviewedPatchesListener object is created (and attempted to be added as a listener for the server) before the connection with Gerrit is actually established. Thus, the attempt to add it as a listener is ignored and it is not able to perform any checks for non-reviewed patchsets. Not sure if this is specific to my use of the plugin or if others are experiencing it as well. Thank you, Ivo Bratanov Jenkins Development Ericsson -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]<mailto:[email protected]>. For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
