On 26/08/14 07:05, Stephen Connolly wrote:
On Monday, 25 August 2014, Slide <[email protected] <mailto:[email protected]>> wrote:There have been a couple times recently where someone from Cloudbees has made changes to email-ext without consulting with me as the maintainer of email-ext. Just recently tfennelly made a change to the parent pom version with no consultation. I consider this to be unacceptable. Any changes to plugins should go through the plugin maintainers (through PR's is fine), regardless if it is a plugin that is heavily used in the enterprise Clousebees offerings. I think it would be really good if plugin maintainers put a "contributing" section in the README in the Git repo. With 1000+ plugins it gets hard to remember the rules of the different maintainers.
But the general rule has always been to contact the maintainer first, which is what applies here — this plugin doesn't seem to be different from any other. For new users, this is mentioned in the Governance Document, linked from the "Extend Jenkins" page:
"If you are interested in just making a small number of changes without an intent to stay. It’s the easiest to send in pull requests through GitHub. See using pull request for more details."
"Try to be courteous to existing developers by sending them heads-up and coordinating with them"
"The safe rule of thumb is to contact existing developers upfront before doing any commit (but if there's no timely response in a week so, you should feel free to commit."
Perhaps the above proposal is something that we should bring to the board. We could then put in place tooling to track whether there is a contribution section and nag the corresponding maintainers
That's not so bad an idea; maybe the plugin archetype could generate such a file (referencing the usual "ask the maintainer" policy). Though I don't know whether public shaming would work any better than similar things like the (dead?) "Pending Pull Requests" wiki page.
But it would be nice to use a CONTRIBUTING file, rather than placing the info in the README. In this case, GitHub would even prompt contributors (assuming they use pull requests) about the contribution guidelines:
https://github.com/blog/1184-contributing-guidelines Regards, Chris -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
