Hello. Thanks for comments. I updated the Wiki page and created new pull requests.
Rather than adding whitelisted methods to manager, it may be useful also for other plugins to provide a whitelisted wrapper for AbstractBuild in script-security plugin. On Saturday, September 13, 2014 7:34:14 PM UTC+9, Daniel Beck wrote: > > Thanks for doing this! > > Consider adding a compatibility warning to increase the likelihood of > users reading the wiki before upgrading. Example: > https://github.com/jenkinsci/build-flow-plugin/blob/master/pom.xml#L106 > > - For users who skip to the changelog, add a link to the migration section > to the 2.0 changelog entry. > - Admins and instances with security disabled will not be affected by > script security. Mention that. > - It's not clear why some methods (removeSummary/Summaries/Badge/Badges) > aren't whitelisted, maybe add a short notice why they're evil. > > Regarding the plugin itself, it may be easier to handle the change with > more whitelisted manager methods that used to be accessible via > build/project (e.g. build.keepLog, build.setDescription, > project.setDescription, ...), but that could always be added later. > > On 13.09.2014, at 11:32, Ikedam <[email protected] <javascript:>> wrote: > > > Hello. > > > > I'm preparing to release Groovy-postbuild plugin 2.0 which introduced > Script Security plugin. > > > > Users may get confused after upgrading to that, and I wrote instructions > to migrate from version 1.X. > > > https://wiki.jenkins-ci.org/display/JENKINS/Groovy+Postbuild+Plugin#GroovyPostbuildPlugin-Migrationfrom1.X > > > > > I'd like to have that reviewed and updated if it is difficult to read. > > > > Regards, > > ikedam > > > > -- > > You received this message because you are subscribed to the Google > Groups "Jenkins Developers" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected] <javascript:>. > > For more options, visit https://groups.google.com/d/optout. > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
