The repo has been forked: https://github.com/jenkinsci/matrix-groovy-execution-strategy-plugin
четверг, 23 октября 2014 г., 12:44:10 UTC+4 пользователь Jeremy Marshall написал: > > I think the plugin can be forked, but it's better to agree on the plugin >>> name before forking. >>> >> > I renamed the plugin to > https://github.com/JeremyMarshall/matrix-groovy-execution-strategy-plugin > >> >>> - What about using http://groovy-sandbox.kohsuke.org/ to run Groovy >>> scripts? Just to avoid new security holes... >>> >>> I'll look into this and add it before release > >> >>> - >>> - > "I think the name could be better " >>> - Definitely. Actually, you don't introduce new project types >>> - I'd propose to use a name like matrix-groovy-execution-strategy >>> (and to name GitHub repo accordingly) >>> - If you don't actually need to manage the execution order, see >>> below >>> - > "I'd like to move the combination filter box into the default >>> plugin box if possible" >>> - There's no extension points for this field >>> >>> The combination filter is only used in the > default implementation - I think its here for legacy reasons > final FilterScript combinationFilter = FilterScript.parse(execution. > getProject().getCombinationFilter(), FilterScript.ACCEPT_ALL); > > from > src/main/java/hudson/matrix/DefaultMatrixExecutionStrategyImpl.java > <https://github.com/jenkinsci/matrix-project-plugin/blob/f6656ca75c3f2f222a3f94e6b1ebd704f3c1c76d/src/main/java/hudson/matrix/DefaultMatrixExecutionStrategyImpl.java> > > > I'm not sure if its possible or desirable to > move it to the default plugin and have a migration strategy (I'll > investigate) > >> >>> - >>> >>> >>> - If somebody implements it, you will be able to reduce the scope of >>> the plugin (and probably rename it) >>> >>> I was hoping to have one place to filter > out combinations you don't want in addition to structuring the execution so > possibly the executers don't get swamped > >> >>> - >>> - > "I wrote it with the gradle-jpi-plugin in groovy" >>> - A Maven spec wrapper could be useful for automatic Pull Request >>> Builder in jenkinsci org (not sure if it supports Gradle now) >>> >>> If this happens for the job-dsl plugin then it > should be possible > > I'll also add in a facility to just use a list of > capabilities for simpler cases > > Thanks > Jeremy > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
