(replies inline)

On Mon, 03 Nov 2014, Elad Shmitanka wrote:

> should I just push to the repo or would it be easier to re-fork as it's a 
> completely new code?


I would force push a new history to the repo if I were in your shoes :)


> 
> On Monday, November 3, 2014 9:26:16 AM UTC+2, Oleg Nenashev wrote:
> >
> > Elad, you should have an access to the plugin now. As I see, R. Tyler also 
> > supported changes in the plugin.
> >
> > You can just start merging your functionality into the plugin.
> > If you want to get a review for your changes, you can always create pull 
> > requests to the plugin (and merge them on your own).
> >
> > BR, Oleg
> >
> > ?????, 29 ??????? 2014 ?., 8:59:01 UTC+3 ???????????? Elad Shmitanka 
> > ???????:
> >>
> >> Thanks Tyler
> >>
> >> About invoking vagrant on another process, are you referring to the fact 
> >> that Jenkins kills it's sub processes in the end of the build during 
> >> cleanup?
> >> Oleg, How can we continue?
> >>
> >> On Tuesday, October 28, 2014 5:50:30 PM UTC+2, R Tyler Croy wrote:
> >>>
> >>> (replies inline) 
> >>>
> >>> On Wed, 22 Oct 2014, Oleg Nenashev wrote: 
> >>>
> >>> > Added R. Tyler to Cc. 
> >>> > Even if the plugin is not maintained now, I'm sure that he will 
> >>> provide 
> >>> > some feedback. 
> >>>
> >>>
> >>> I think it is fine for this plugin to take the place of the Ruby-based 
> >>> Vagrant 
> >>> VM which is definitely not much more than an interesting experiment. 
> >>>
> >>> One thing caution you about Elad is the use invocation of Vagrant in a 
> >>> separate 
> >>> process from the JVM, which can be goofy and cause problems. THat was 
> >>> the 
> >>> primary motivation I had for attempting to implement a pure-Ruby Vagrant 
> >>> plugin. 
> >>>
> >>>
> >>> Anyways have fun! 
> >>>
> >>> > 
> >>> > 2014-10-22 9:45 GMT+04:00 Elad Shmitanka <[email protected]>: 
> >>> > 
> >>> > > The current vagrant plugin isn't mailntained and tries to run the 
> >>> vagrant 
> >>> > > on the jenkins host and not on the node (according to what I've 
> >>> tries to 
> >>> > > run) 
> >>> > > The new plugin will also support more option such as creating a box, 
> >>> > > suspend a box, and possibly also use vagrant cloud. 
> >>> > > The current plugin doesn't support multi-vm vagrant file 
> >>> > > 
> >>> > > I can try and take ownership on the plugin and over-write with my 
> >>> own if 
> >>> > > needed 
> >>> > > 
> >>> > > The current code is built in ruby whereas my code is pure java 
> >>> > > 
> >>> > > 
> >>> > > On Wednesday, October 22, 2014 7:26:27 AM UTC+3, Oleg Nenashev 
> >>> wrote: 
> >>> > >> 
> >>> > >> Hello Elad, 
> >>> > >> 
> >>> > >> Jenkins already has a plugin for Vagrant: 
> >>> https://wiki.jenkins-ci.org/ 
> >>> > >> display/JENKINS/Vagrant+Plugin 
> >>> > >> 
> >>> > >>    - What new functionality does your plugin introduce? 
> >>> Descriptions are 
> >>> > >>    very similar 
> >>> > >>    - Is it possible to merge the existing functionality to the 
> >>> existing 
> >>> > >>    plugin? 
> >>> > >> 
> >>> > >> BR, Oleg Nenashev 
> >>> > >> 
> >>> > >> ???????, 21 ??????? 2014 ?., 16:57:49 UTC+4 ???????????? Elad 
> >>> Shmitanka 
> >>> > >> ???????: 
> >>> > >>> 
> >>> > >>> I know there is one, it's old, not maintained and not working.... 
> >>> > >>> I'd be happy to publish it, although it doesn't support ALL 
> >>> operations 
> >>> > >>> (more to come) 
> >>> > >>> 
> >>> > >>> Plugin name: vagrant 
> >>> > >>> Github-ID: ShimiTaNaka 
> >>> > >>> Existing github: https://github.com/myheritage/jenkins-vagrant 
> >>> > >>> 
> >>> > >>> Thanks 
> >>> > >>> 
> >>> > >>  -- 
> >>> > > You received this message because you are subscribed to a topic in 
> >>> the 
> >>> > > Google Groups "Jenkins Developers" group. 
> >>> > > To unsubscribe from this topic, visit 
> >>> > > 
> >>> https://groups.google.com/d/topic/jenkinsci-dev/rscpCrMHoZs/unsubscribe. 
> >>>
> >>> > > To unsubscribe from this group and all its topics, send an email to 
> >>> > > [email protected]. 
> >>> > > For more options, visit https://groups.google.com/d/optout. 
> >>> > > 
> >>>
> >>> - R. Tyler Croy 
> >>>
> >>> ------------------------------------------------------ 
> >>>      Code: <https://github.com/rtyler> 
> >>>   Chatter: <https://twitter.com/agentdero> 
> >>>
> >>>   % gpg --keyserver keys.gnupg.net --recv-key 3F51E16F 
> >>> ------------------------------------------------------ 
> >>>
> >>
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to [email protected].
> For more options, visit https://groups.google.com/d/optout.

- R. Tyler Croy

------------------------------------------------------
     Code: <https://github.com/rtyler>
  Chatter: <https://twitter.com/agentdero>

  % gpg --keyserver keys.gnupg.net --recv-key 3F51E16F
------------------------------------------------------

Attachment: pgphVTYgVK480.pgp
Description: PGP signature

Reply via email to