So looking at this a little further, it looks like: https://github.com/jenkinsci/build-flow-plugin/pull/50 https://github.com/jenkinsci/buildgraph-view/pull/9
were submitted at the same time by sjoroos. I think that sjoroos meant both those changes to go into those separate plugins at the same time. You (nicolas) merged in PR 50, but you did not merge in PR 9. This effectively broke the buildgraph-view plugin since August. Since you rejected https://github.com/jenkinsci/buildgraph-view/pull/12 which is an updated version of PR 9, then what alternative do you have for buildgraph-view? You effectively broke it by merging PR 50, without taking PR 9. Thanks. -- Craig On Wed, Nov 26, 2014 at 8:30 AM, Craig Rodrigues <[email protected]> wrote: > Hi, > > OK, I see you closed my pull request. > You should close https://github.com/jenkinsci/buildgraph-view/pull/9 as > well, > since it is the same patch, just an older version. > > Do you have another fix in mind? buildgraph-view has been broken > since this change to buildflow: > > https://github.com/jenkinsci/build-flow-plugin/pull/50 > > -- > Craig > > > On Wed, Nov 26, 2014 at 3:04 AM, nicolas de loof <[email protected] > > wrote: > >> I probably just missed your email. >> >> I commented on your pull request. I'm -1 on reverting dependency order. >> The rendering issue in build flow should be addressed there from the >> (optional) component to provide integration. >> >> 2014-11-26 2:50 GMT+01:00 Craig Rodrigues <[email protected]>: >> >>> Hi, >>> >>> Please grant me write access to jenkinsci/buildgraph-view. My github id >>> is rodrigc. >>> >>> I contacted Nicolas De loof about this plugin in private e-mail but >>> received no response. >>> >>> I submitted this pull request: >>> https://github.com/jenkinsci/buildgraph-view/pull/12 >>> which fixes the plugin so that it displays build graphs. After recent >>> changes >>> to the buildflow plugin, the buildgraph plugin stopped displaying. >>> >>> Thanks. >>> -- >>> Craig >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3DrPVcB_B2feMsX0o_BCPCQxwwwu3mB9OGZGkGkTtT6qe%2BsJA%40mail.gmail.com >>> <https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3DrPVcB_B2feMsX0o_BCPCQxwwwu3mB9OGZGkGkTtT6qe%2BsJA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CANMVJznO5pvPz4Rgd7rDRrD0%3DuMeTcSdLYrdaP8wP%3DoJzXC7Cg%40mail.gmail.com >> <https://groups.google.com/d/msgid/jenkinsci-dev/CANMVJznO5pvPz4Rgd7rDRrD0%3DuMeTcSdLYrdaP8wP%3DoJzXC7Cg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3DrPVfu1Lk5VZqqEsawvLLFdEbUFDHCNje3ZdjAS9gm%3DOq_Ow%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
