Hi, Oleg found one small issue which I've now fixed and the tests are coming back green. Michael has reviewed and approved the fix. Is there anything else I need to do to get this patch merged?
Cheers Dave On Monday, December 1, 2014 10:39:11 PM UTC+11, Dave Hall wrote: > > Hi, > > I have updated the code in the PR based on the feedback. It has been idle > for about a week. I'd appreciate another review at > https://github.com/jenkinsci/notification-plugin/pull/15 > > Is it project policy to squash commits or is it ok as it is with the 3 > commits? > > Cheers > > Dave > > On Tuesday, November 18, 2014 2:06:38 PM UTC+11, Dave Hall wrote: >> >> Hi, >> >> Thanks to Oleg and Michael for providing feedback on the PR. I will fix >> the issues raised and continue the discussion on the PR. >> >> Thanks again >> >> Dave >> >> On Sunday, November 16, 2014 2:16:27 PM UTC+11, Dave Hall wrote: >>> >>> Hi, >>> >>> Around a month ago I submitted a PR for the notification plugin - see >>> https://github.com/jenkinsci/notification-plugin/pull/15 There hasn’t >>> been any response on the issue. I’d really appreciate a review. >>> >>> I know enough java to be dangerous, but I don’t feel that I have the >>> skills and/or knowledge to (co-)maintain this plugin. >>> >>> Cheers >>> >>> Dave >>> >>> -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/4ad39ad2-242d-43d1-bb5b-01fb6a8b08d4%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
