Hi all,
The plugin does not run cucumber but a specific (ruby) implementation.
Therefore if this plugin was to be forked I would prefer that either
1) it would in future accept pull request to run other cucumber
implementations
or
2) it would be remanbed to cucumber-ruby-builder-plugin (or something
more specific).
Also I believe the name cucumber-plugin is too generic - there are
already other cucumber plugins out there - this is specifically a
cucumber builder.
I also think it seems to be specific to the OPs need - in that it
assumes the use of a browser (chrome/firefox) and a display - neither of
which are required for running cucumber (jvm at least) and assumes
running on Linux, requires the use of profiles (I believe if you don;t
have a cucumber profile file then cucumber will barf when trying to load
it) etc.
| 1) Usually everybody run cucumber from native ....
you do not need to grab test results if you use this plugin, you just
run it as is, and have builder step failed or pass whether your
cucumber tests are ok or not.
Cucumber will (should?!?) return an exit code to say if it passed or
failed - so you don't have to parse the json output etc to know if some
tests failed.
However what is the point in knowing some tests failed if you don't know
what failed?
If you just want to ignore test failures then on linux/unix you can do
this from native just run "set +e" if your bash script before invoking
the native tool. (or use 'command || echo "test failed" ' syntax).
/James
On 19/12/2014 09:05, melezhik wrote:
Kanstantin, thank you for your opinion. My replies your comments.
| 1) Usually everybody run cucumber from native ....
you do not need to grab test results if you use this plugin, you just
run it as is, and have builder step failed or pass whether your
cucumber tests are ok or not.
| 2) part of commit messages are in russian, not really convenient for
contributing by other people
it's not a problem at all, if someone clear some details one may as in
English, other comments of course may be written in English in case of
any collaboration, right now I just cannot see any ...)))
| 3) If you want wrote your commands in ruby, then you can just use
shell execution step with #!/bin/env ruby
this is about implementation, plugin users should not care about this,
but if to go into technical dispute I cannot see strong difference
between your approach ( use shell scripts , or other "shell" plugins )
and mine ( using system() calls inside ruby ).
Well, one day I even may choose better tools to handle IPC stuff,
like ruby open3 module, or something like that; right now system()
way is straightforward approach, but that is seemed enough.
| Imho this plugin looks absolutely useless for hosting at infra, few
shell commands implemented like a plugin will be unreally difficult to
support.
so many thing can be expressed in few lines of bash code, is not it?
))) , but this definitely breaks encapsulation principal , while
plugins give us freedom to change implementation while stick to public
interface ...
вторник, 16 декабря 2014 г., 17:00:56 UTC+3 пользователь Kanstantsin
Shautsou написал:
What is the main goal of this plugin?
1) Usually everybody run cucumber from native packagers/tools and
then just grab test results in i.e.
https://wiki.jenkins-ci.org/display/JENKINS/Cucumber+Test+Result+Plugin
<https://wiki.jenkins-ci.org/display/JENKINS/Cucumber+Test+Result+Plugin>
2) part of commit messages are in russian, not really convenient
for contributing by other people
3)
https://github.com/melezhik/cucumber-plugin/blob/master/models/cucumber-builder.rb#L65-L67
<https://github.com/melezhik/cucumber-plugin/blob/master/models/cucumber-builder.rb#L65-L67>
If you want wrote your commands in ruby, then you can just use
shell execution step with #!/bin/env ruby and your script or
install some plugin that can highlight ruby syntax. All input
variable can be define as input strings or just in this shell
script...
Imho this plugin looks absolutely useless for hosting at infra,
few shell commands implemented like a plugin will be unreally
difficult to support. (Note, it just my opinion.)
On Tuesday, December 16, 2014 2:12:54 PM UTC+3, melezhik wrote:
Hi! I want to add this to jenkins plugins list. Cucumber
jenkins plugin to run cucumber features through jenkins.
https://github.com/melezhik/cucumber-plugin
<https://github.com/melezhik/cucumber-plugin>
Regards.
Alexey
--
You received this message because you are subscribed to the Google
Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected]
<mailto:[email protected]>.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/a0b01d0f-e91b-4516-abfb-c32a6cfec4ed%40googlegroups.com
<https://groups.google.com/d/msgid/jenkinsci-dev/a0b01d0f-e91b-4516-abfb-c32a6cfec4ed%40googlegroups.com?utm_medium=email&utm_source=footer>.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "Jenkins
Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/5494044E.40401%40teilo.net.
For more options, visit https://groups.google.com/d/optout.
