Thanks Daniel.
Yeah, should be easy enough to insert default styles.
As for using the @Extension annotation, yes it would be a little less
invasive but my original thinking (may no longer be valid having the
benefit of hindsight) was that doing it through extension made it easier
for us to keep track of what plugins are theme contributors, and so,
remove them from the contributor list as the plugin is uninstalled. In
hindsight though it seems like plugins are not really uninstalled until
after a restart, so it might not matter and maybe @Extension would work
and if so then the abstract impl would work as you suggest.
On 06/01/2015 13:36, Daniel Beck wrote:
The video looks really interesting. Here's the correct link BTW (I only see a
link to the thumbnail image): https://www.youtube.com/watch?v=ZlD0zf1VCAs
Since theme implementations may be incomplete, is there a way to define a fallback, to get e.g.
"black and white gif icons" as a fallback when "font awesome" is not
implemented for sidepanel icons?
---
Is it a requirement to subclass Plugin, or can UIThemeContributor be used with
@Extension? If not, why not? It seems this would make adding support for
various themes to plugins far less invasive. Just add a random @Extension
FooThemeSupport class somewhere in the plugin and done.
Also, since UIThemeContributor is an interface, wouldn't it make sense to also
have an (abstract) class to subclass from, so later additions to the API will
not break existing implementations of the interface?
On 06.01.2015, at 12:41, Tom Fennelly <[email protected]> wrote:
Thanks Ulli.
Plugins can "contribute" to a theme "implementation" in the very same way as Jenkins Core does.
Therefore, it can "contribute" icon style definitions to multiple icon theme "implementations". See
https://github.com/jenkinsci/uithemes-plugin#registering-and-contributing-to-themes for a bit more info on this.
On 05/01/2015 21:59, Ulli Hafner wrote:
That looks very promising!
How would this concept integrate with plus-ins? Does a theme provide icons for
plug-ins, too? Or is each plug-in providing icons for each available theme?
Am 05.01.2015 um 18:56 schrieb Tom Fennelly <[email protected]>:
I got back to doing a little bit of Jenkins Core UI work in the last few weeks.
I've evolved the uithemes-plugin a bit further in the last few weeks, to a
stage now where (on this branch) a user can perform personalized theme
configurations such as:
• Status Balls/Orbs
• Page Header
• Icons
• Console/terminal (ala PR #1272 from @kevinburke)
More info on uithemes-plugin, as well as short video:
http://img.youtube.com/vi/ZlD0zf1VCAs/0.jpg
I also created a WIP pull request at #1512. Might be better to have any
conversations over there.
--
You received this message because you are subscribed to the Google Groups "Jenkins
Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/9523f33b-78c9-417b-9035-971f0e471036%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the Google Groups
"Jenkins Developers" group.
To unsubscribe from this topic, visit
https://groups.google.com/d/topic/jenkinsci-dev/VaTOWEZHyfI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
[email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/2C0AF241-9FFA-4DF0-8843-9397C05212EC%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "Jenkins
Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/54ABC9DD.4090701%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "Jenkins
Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/54AD1413.7020401%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
