On 01/06/2015 09:50 PM, Jesse Glick wrote:
> On Tue, Jan 6, 2015 at 9:45 AM, René Scheibe <[email protected]> wrote:
>> It says that is has 1 pending check and failed checks - see the attached
>> screenshot.
>>
>> Can anybody shed some light on this?
> 
> It is a bug in the PR builder plugin. Kohsuke said he would look at it.
FYI, what I got back from GitHub support.

So we fix a) the Details link and they have a look at b) the Status message.

René

On 01/07/2015 10:19 AM, Ivan Žužak wrote:
> Hi René,
> 
> Thanks for getting in touch and providing those details -- that's helpful.
> 
> To answer your second question first -- yeah, I agree that the text is a bit 
> misleading when it says that there are failed checks. I'll open an internal 
> issue for this and follow up with you when there's any news.
> 
> As for what the "Details" links point to -- there's not much we can do about 
> that. Those links are defined by the statuses created for the commit, and 
> those statuses are not created by us. You can see the statuses for that 
> specific commit here:
> 
> https://api.github.com/repos/jenkinsci/jenkins/statuses/711e5233f3c6c3777613541d8a988932f3b64a02
> 
> The URL which is used for the Details link is the "target_url". However, 
> statuses are grouped by  "context", as documented here:
> 
> https://developer.github.com/v3/repos/statuses/
> 
> So, if multiple statuses are created with different contexts, the latest 
> status for each context will be used and the target_url of those statuses 
> will determine what the Details link points to.
> 
> In the statuses created for that commit, I don't see anything related to 
> "acceptance-test-harness", as you mentioned. Can you double-check your build 
> process and see that such statuses are really created?  Let me know if this 
> doesn't explain the behavior you observed or if I misunderstood anything.
> 
> Cheers,
> Ivan
> 
>> Im talking for example about the pull request: 
>> https://github.com/jenkinsci/jenkins/pull/1515.
> The current status looks like this:
> ![pull-request-jenkins-status](https://cloud.githubusercontent.com/assets/16874/5631684/a0bf0ff6-95c8-11e4-92ba-4c5bcc8df95d.png)
> 
> Relevant detail: The "jenkins-core" project has a downstream project 
> "acceptance-test-harness".
> 
> The current behavior is really confusing because:
> a) Both "Details" links link to the same build 
> (https://jenkins.ci.cloudbees.com/job/core/job/jenkins-core/1891/).
> b) It says "This branch has failed checks..." but it hasn't.
> 
> Expectations:
> a) One "Detail" link should link to the "jenkins-core" build and one to the 
> "acceptance-test-harness" build.
> b) It should say "This branch has pending checks..."

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/54AD24BE.6010507%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to