Hi Guys,
Just started to update the P4 SCM plugin moving AbstractBuild to Run and
AbstractProject to Job.
Previously I added some environment variables by
extending buildEnvVars(AbstractBuild<?, ?> build, Map<String, String> env),
however when I looked at the new implementation in SCM it seems unfinished.
/**
* Adds environmental variables for the builds to the given map.
*
* <p>
* This can be used to propagate information from SCM to builds
* (for example, SVN revision number.)
*
* <p>
* This method is invoked whenever someone does {@link
AbstractBuild#getEnvironment(TaskListener)}, which
* can be before/after your checkout method is invoked. So if you are going
to provide information about
* check out (like SVN revision number that was checked out), be prepared
for the possibility that the
* check out hasn't happened yet.
*/
// TODO is an equivalent for Run needed?
public void buildEnvVars(AbstractBuild<?,?> build, Map<String, String> env)
{
// default implementation is noop.
}
Should this method be abstract or at least updated to use Run?
Kind regards,
Paul
--
You received this message because you are subscribed to the Google Groups
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/8a23acc2-17b3-46af-8312-fc2df574acda%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
