Hi Guys, sorry for bothering you, is it really a big issue to arrange releasing of this simple change? SectionedListView is missing setter of include regex that is kind of equivalent in Jenkins ListView,
Can I commit such a change? with best regards Lukasz Łukasz Tasz 2015-02-03 10:29 GMT+01:00 Łukasz Tasz <[email protected]>: > yep extension is like adding Public in front of includeRegex field... > > with best regards > Lukasz > Łukasz Tasz > > > 2015-02-02 12:33 GMT+01:00 Daniel Beck <[email protected]>: >> Sorry about that, only now saw the earlier discussion. Would probably need >> to extend Sectioned View. >> >> On 02.02.2015, at 12:31, Daniel Beck <[email protected]> wrote: >> >>> It has public getters and setters (since 1.526). The setter code will also >>> show you why accessing the field directly would be a horrible idea. >>> >>> On 02.02.2015, at 10:56, Łukasz Tasz <[email protected]> wrote: >>> >>>> Hi Guys, any possiblilities to make field includeRegex public? >>>> >>>> regards >>>> Lukasz >>>> Łukasz Tasz >>>> >>>> >>>> 2015-01-21 13:33 GMT+01:00 Łukasz Tasz <[email protected]>: >>>>> I"m using and testing latest version with code: >>>>> >>>>> private String name; >>>>> /** >>>>> * Include regex string. >>>>> */ >>>>> String includeRegex; >>>>> /** >>>>> * Compiled include pattern from the includeRegex string. >>>>> */ >>>>> transient Pattern includePattern; >>>>> >>>>> includePattern I don't need to touch, since readResolve() will do >>>>> this, all we(I) need is seter for includeRegex, or possiblility to set >>>>> this. >>>>> >>>>> >>>>> with best regards >>>>> Lukasz >>>>> Łukasz Tasz >>>>> >>>>> >>>>> 2015-01-21 12:49 GMT+01:00 Robert Sandell <[email protected]>: >>>>>> Ok, so you'll need to look at the code for the version of the plugin you >>>>>> are >>>>>> running. >>>>>> >>>>>> On Wed, Jan 21, 2015 at 11:51 AM, Łukasz Tasz <[email protected]> wrote: >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> tried, does not work, it I'm touching includeRegex, jenkins claims >>>>>>> that I'm changing read-only field, if @... claims not such property. >>>>>>> would be realy nice to find something which does not require own >>>>>>> plugin changes.. maitenance is then a hell.... >>>>>>> >>>>>>> thanks in advance >>>>>>> L. >>>>>>> >>>>>>> Łukasz Tasz >>>>>>> >>>>>>> >>>>>>> 2015-01-21 10:46 GMT+01:00 Robert Sandell <[email protected]>: >>>>>>>> So try; >>>>>>>> >>>>>>>> def regexp = "^dupa123" >>>>>>>> d1e35.@includeRegex = regexp >>>>>>>> d1e35.@includePattern = Pattern.compile(regexp) >>>>>>>> >>>>>>>> On Tue, Jan 20, 2015 at 1:41 PM, Łukasz Tasz <[email protected]> wrote: >>>>>>>>> >>>>>>>>> ok went throu! >>>>>>>>> >>>>>>>>> instead of: >>>>>>>>> d1e35.columns.add(hudson. >>>>>>>>> >>>>>>>>> >>>>>>>>> model.Hudson.instance.<ListViewColumn,Descriptor<ListViewColumn>>getDescriptorList(hudson.views.JobColumn.class)) >>>>>>>>> it's enough to: >>>>>>>>> >>>>>>>>> d1e35.columns.add(new hudson.views.JobColumn) >>>>>>>>> >>>>>>>>> Guys, do you know whom we can trigger to make includeRegex field >>>>>>>>> public in sectionedView plugin? >>>>>>>>> >>>>>>>>> regards >>>>>>>>> L. >>>>>>>>> Łukasz Tasz >>>>>>>>> >>>>>>>>> >>>>>>>>> 2015-01-20 13:15 GMT+01:00 Łukasz Tasz <[email protected]>: >>>>>>>>>> Hi Robert, >>>>>>>>>> >>>>>>>>>> this is what I tried, but then it claims that includeRegex is >>>>>>>>>> readOnly... >>>>>>>>>> >>>>>>>>>> SectionedViewSection has no setter, and field includeRegex is defined >>>>>>>>>> as: >>>>>>>>>> String includeRegex; >>>>>>>>>> public String includeRegex; >>>>>>>>>> >>>>>>>>>> is fixing issue, would be nice to have it also in official plugin. >>>>>>>>>> >>>>>>>>>> Now I'm strugling with columns... descriptor creates column with >>>>>>>>>> line: >>>>>>>>>> >>>>>>>>>> section.columns.rebuildHetero(req, formData, >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Hudson.getInstance().<ListViewColumn,Descriptor<ListViewColumn>>getDescriptorList(ListViewColumn.class), >>>>>>>>>> "columns"); >>>>>>>>>> >>>>>>>>>> I'm trying with: >>>>>>>>>> d1e35.columns = new >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> DescribableList<ListViewColumn,Descriptor<ListViewColumn>>(Saveable.NOOP); >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> d1e35.columns.add(hudson.model.Hudson.instance.<ListViewColumn,Descriptor<ListViewColumn>>getDescriptorList(hudson.views.JobColumn.class)) >>>>>>>>>> >>>>>>>>>> but getDescriptorList returns empty list... diging :) >>>>>>>>>> thanks a lot for your help! >>>>>>>>>> br >>>>>>>>>> L. >>>>>>>>>> Łukasz Tasz >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> 2015-01-20 13:08 GMT+01:00 Robert Sandell <[email protected]>: >>>>>>>>>>> I think you can set the fields directly >>>>>>>>>>> >>>>>>>>>>> def regexp = "^dupa123" >>>>>>>>>>> d1e35.includeRegex = regexp >>>>>>>>>>> d1e35.includePattern = Pattern.compile(regexp) >>>>>>>>>>> >>>>>>>>>>> On Tue, Jan 20, 2015 at 9:58 AM, Łukasz Tasz <[email protected]> wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hi All!! >>>>>>>>>>>> >>>>>>>>>>>> I have a question, since you about view-section-plugin. >>>>>>>>>>>> >>>>>>>>>>>> I would like to create list-view-section in a automated way - not >>>>>>>>>>>> using gui, just from script console, >>>>>>>>>>>> so far so good: >>>>>>>>>>>> >>>>>>>>>>>> d1e28=new SectionedView("test section") >>>>>>>>>>>> d1e28.initSections() >>>>>>>>>>>> d1e35=new ListViewSection("STATUS", SectionedViewSection.Width. >>>>>>>>>>>> FULL, >>>>>>>>>>>> SectionedViewSection.Positioning.CENTER) >>>>>>>>>>>> >>>>>>>>>>>> I have sectioned view, at least one section but I don't have >>>>>>>>>>>> regex... >>>>>>>>>>>> //d1e35.setIncludeRegex("^dupa123") >>>>>>>>>>>> >>>>>>>>>>>> is not avaliable - since SectionedViewSection dont extend ListView, >>>>>>>>>>>> I'm not java expert, but as I see ListViewSection has inside >>>>>>>>>>>> DesctriptorImpl which extends SectionedViewSectionDescriptor which >>>>>>>>>>>> in >>>>>>>>>>>> constructor reads regex from "magic stapler" (maybe only for me :D >>>>>>>>>>>> ) >>>>>>>>>>>> >>>>>>>>>>>> Do you have any clue how I should proceed? should I implement >>>>>>>>>>>> sectionedViewSectionDescriptor constructor which takes not >>>>>>>>>>>> "stapler" >>>>>>>>>>>> but regex? Unfortunately this plugin is only gui oriented - at >>>>>>>>>>>> least >>>>>>>>>>>> what I see... >>>>>>>>>>>> >>>>>>>>>>>> thanks in advance & regards >>>>>>>>>>>> Lukasz >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>>>>> Groups >>>>>>>>>>>> "Jenkins Developers" group. >>>>>>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>>>>>> send >>>>>>>>>>>> an >>>>>>>>>>>> email to [email protected]. >>>>>>>>>>>> To view this discussion on the web visit >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/2b5d54c5-2a01-49b0-a913-579eed3a0a77%40googlegroups.com. >>>>>>>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Robert Sandell >>>>>>>>>>> Software Engineer >>>>>>>>>>> CloudBees Inc. >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>>>> Groups >>>>>>>>>>> "Jenkins Developers" group. >>>>>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>>>>> send >>>>>>>>>>> an >>>>>>>>>>> email to [email protected]. >>>>>>>>>>> To view this discussion on the web visit >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS06dh50dLWKW-JygSS2BMXwLm0-X%2By0-qnQ6u9-ua7h-g%40mail.gmail.com. >>>>>>>>>>> >>>>>>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>> Groups >>>>>>>>> "Jenkins Developers" group. >>>>>>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>>>>>> an >>>>>>>>> email to [email protected]. >>>>>>>>> To view this discussion on the web visit >>>>>>>>> >>>>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAGRr-NiqkZoMHxocLuTc5G0xac%2BZFeYN3P%3DuQh9ciO10z6MAdQ%40mail.gmail.com. >>>>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Robert Sandell >>>>>>>> Software Engineer >>>>>>>> CloudBees Inc. >>>>>>>> >>>>>>>> -- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups >>>>>>>> "Jenkins Developers" group. >>>>>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>>>>> an >>>>>>>> email to [email protected]. >>>>>>>> To view this discussion on the web visit >>>>>>>> >>>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS1mLCmg-1C3Kyi7hVNOf1djCZ8HF7x8cfLb-yjiF9SFiw%40mail.gmail.com. >>>>>>>> >>>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>> >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups >>>>>>> "Jenkins Developers" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>>>> an >>>>>>> email to [email protected]. >>>>>>> To view this discussion on the web visit >>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAGRr-Nhtqz1uQ4gXvh0XbWRvNegmZs8wVm4cjte80DzpnrBZ-A%40mail.gmail.com. >>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Robert Sandell >>>>>> Software Engineer >>>>>> CloudBees Inc. >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google Groups >>>>>> "Jenkins Developers" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, send an >>>>>> email to [email protected]. >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS3doTSXO3MrmBGDq3AVUTkA747CkPDZLroRC1%2BzEvHVAg%40mail.gmail.com. >>>>>> >>>>>> For more options, visit https://groups.google.com/d/optout. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups >>>> "Jenkins Developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send an >>>> email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAGRr-NhdQ9mG1gF_EzqqFNaCBrLHD1AjiW_MzdXXX4JV%3DVsPCg%40mail.gmail.com. >>>> For more options, visit https://groups.google.com/d/optout. >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/10FC5C18-001F-471C-A269-AACBF4B002DA%40beckweb.net. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/3FE96E2F-3C79-46FE-BE7E-1CDDBEFC1826%40beckweb.net. >> For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAGRr-NgvefWgXaQ0tvN6x53ktY%2BxRGSwkwEVhRijYdF%3DfuJDvw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
