On Mon, Mar 2, 2015 at 11:28 AM, Suckow, Thomas J <[email protected]> wrote: > Any feedback is welcome. Even "Your PR sucks because of X," because then I > know what needs to be fixed.
For https://github.com/jenkinsci/jenkins/pull/1569 what is missing at first glance is a test case to reproduce the problem. I understand that you struggled to write such a test and could not, but that just means that someone who does know how to write the test needs to spend time working on it. We do strive to review incoming PRs but they come in at quite a pace, and many are not in mergeable condition when filed. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1FyiF8QDhqN-s-n9E81u6pQ7nBZZqmG1%2B4Ei0Vn%3DXObg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
