*Summary of Request* I'm refactoring TimerTrigger.doCheckSpec() to make use of FormValidator.aggregate() and need help finding a spot to add tests for my changes.
*Background and Link To Initial Code* It's been bugging me that the CronTab FormValidator's clobber each other. I've been wanting to dig into the codebase for jenkins core for some time and this seemed like an easy thing to fix. Searching through the core component tickets for cron, I didn't see a ticket related to this topic. So, I created JENKINS-27230 <https://issues.jenkins-ci.org/browse/JENKINS-27230> with some screenshots demonstrating what I'm trying to accomplish. I've got a code change to submit as a pull-request <https://github.com/jenkinsci/jenkins/compare/master...timsnyder:JENKINS-27230?expand=1> but I'm struggling a bit trying to find a good place to add a test. Should I create TimerTrigger unit tests somewhere in the test subtree? Am I missing existing tests? *FYI Resolved Unrelated Ticket That Looks Fixed* Mildly related, while searching for an already existing ticket to take and resolve, I did find https://issues.jenkins-ci.org/browse/JENKINS-10474. It seems like that's been fixed somewhere along the way. I resolved it as Cannot Repro in master with the sha I was looking at and a screenshot of the fix. Perhaps I should have assigned the ticket to myself as well but I didn't. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c9640b6c-e91d-4c5d-8caf-4429261a2692%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
