As i see PR was merged with ignorance of provided comments. Why did you ask for review?
Small history how this PR appeared: I put meeting item for discussing AbortException handling to get some clarification, because this functionality in core looks bad implemented (AbortException was implemented, but wasn't handled right anywhere). Now post-build action flows can't be handled right because of broken behaviours https://issues.jenkins-ci.org/browse/JENKINS-26964 and different implementation in plugins. As fast solution to bypass core issue i decided to use flexible publish, but got similar issue with wrong statuses handling. I proposed fix to this clear issue https://github.com/jenkinsci/flexible-publish-plugin/pull/9 , but instead ikedam started spreading idea of changing default execution strategies everywhere https://github.com/jenkinsci/matrix-project-plugin/pull/16 I will be glad if some experienced developer will review this changes because i doubt https://github.com/jenkinsci/flexible-publish-plugin/pull/10#issuecomment-77780535 As i see Daniel Beck also decided to put this PR under my questions https://wiki.jenkins-ci.org/pages/diffpagesbyversion.action?pageId=54722987&selectedPageVersions=361&selectedPageVersions=360 . I'm not interesting on using meeting time for flexible-publish and have more generic questions for discussion: - AbortException behaviour in core - Some agreement not to broke existed strategies/behaviours On Saturday, March 14, 2015 at 7:05:32 AM UTC+3, Ikedam wrote: > > Hello. > > I plan to introduce a new feature "execution strategy" to flexible-publish > (https://wiki.jenkins-ci.org/display/JENKINS/Flexible+Publish+Plugin). > > It controls the behavior of flexible-publish when a publisher configured > to be contained in flexible-publish fails. > > I want reviews and comments for that change: > https://github.com/jenkinsci/flexible-publish-plugin/pull/12 > > I appreciate any comments especially from those developers: > * Developers interested in flexible-publish. > * Developers using flexible-publish in their environments. > * Developers who know much about how projects handle publishers in Jenkins > core and major plugins. > > Regards, > ikedam > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/d360a20d-027d-4e51-802a-b640f3933d65%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
