On Saturday, March 28, 2015 at 10:05:01 PM UTC+3, Jesse Glick wrote:
>
> OnceRetentionStrategy has no descriptor because it makes no sense to 
> select on a static slave, and clouds generally hardcode the desired 
> strategy.
>
1) Every plugin that uses it creates own UI form with different help files 
and UI, it will be good to provide a standard out-of-the box 
implementations. 
2) It extends Describable and has no descriptor for doing lookup, there is 
no way to provide choosing different Cloud strategies for end user like it 
done for Always/Simple.
 

> It cannot be used with multiple executors, that would make no sense either.
>
3) Thing that DumbSlave is not compatible with this strategy is also under 
question, for example i want accept only one job and then delete DumbSlave. 
This is a question of how end user may want to use it. Running some slaves 
in certain time in cloud is also valid use case imho.
4) Why no sense? Some users wants to have 2 executers on slave 
 https://github.com/jenkinsci/docker-plugin/pull/174 . The only difference 
that i see between Once and Cloud that once supports not killing slave 
until durable task isn't end. Such slave may accept 2 or other number of 
executors and don't kill if they running.

>From my viewpoint core should provide right implemented classes: 
descriptor+ui form or it should be converted to 
abstract 
https://github.com/jenkinsci/jenkins/commit/f62fff5c0ca5091e9e7bc5945ea3a582ee3db3a4
 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/798b3208-2757-4b67-8acf-602180b2a1d8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to