Git plugin has design issues, that's why single fixes that resolve only one small part of issue and adding other problems not merged.
On Saturday, April 25, 2015 at 2:15:18 PM UTC+3, Christian Galsterer wrote: > > Thanks for looking into the PR. > > On Saturday, April 25, 2015 at 1:03:03 PM UTC+2, nicolas de loof wrote: >> >> I've been on vacation for 2 weeks, will review your PR asap. Please note >> 1 week for such a popular plugin is not a long delay to wait for >> review/feedback. >> >> Le sam. 25 avr. 2015 12:28, Christian Galsterer <[email protected]> a >> écrit : >> >>> Hi, >>> >>> you are right. I updated the code already a week ago, but I didn't left >>> a reply on the review comment. I left a comment now. >>> >>> Br >>> Christian >>> >>> On Saturday, April 25, 2015 at 10:59:47 AM UTC+2, Daniel Beck wrote: >>> >>>> >>>> On 25.04.2015, at 07:21, Christian Galsterer <[email protected]> >>>> wrote: >>>> >>>> > without feedback >>>> >>>> What about the review comment you got? >>>> >>>> Note that there's no notification when a pull request is updated, so a >>>> simple 'I addressed your review comment' would be helpful. >>>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/ce11e102-2a63-4d48-8e59-3ebc22a171d5%40googlegroups.com >>> >>> <https://groups.google.com/d/msgid/jenkinsci-dev/ce11e102-2a63-4d48-8e59-3ebc22a171d5%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/024f0e16-53d7-4b97-8c50-5dd418f51fb5%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
