Hi, it was about https://github.com/jenkinsci/git-plugin/pull/315, but I saw that you found the PR in the meantime and it is already merged.
Thanks for reviewing and merging. Br Christian On Monday, April 27, 2015 at 11:22:44 AM UTC+2, nicolas de loof wrote: > > Which PR is this about ? > > 2015-04-25 13:15 GMT+02:00 Christian Galsterer <[email protected] > <javascript:>>: > >> Thanks for looking into the PR. >> >> On Saturday, April 25, 2015 at 1:03:03 PM UTC+2, nicolas de loof wrote: >>> >>> I've been on vacation for 2 weeks, will review your PR asap. Please note >>> 1 week for such a popular plugin is not a long delay to wait for >>> review/feedback. >>> >>> Le sam. 25 avr. 2015 12:28, Christian Galsterer <[email protected]> a >>> écrit : >>> >>>> Hi, >>>> >>>> you are right. I updated the code already a week ago, but I didn't left >>>> a reply on the review comment. I left a comment now. >>>> >>>> Br >>>> Christian >>>> >>>> On Saturday, April 25, 2015 at 10:59:47 AM UTC+2, Daniel Beck wrote: >>>> >>>>> >>>>> On 25.04.2015, at 07:21, Christian Galsterer <[email protected]> >>>>> wrote: >>>>> >>>>> > without feedback >>>>> >>>>> What about the review comment you got? >>>>> >>>>> Note that there's no notification when a pull request is updated, so a >>>>> simple 'I addressed your review comment' would be helpful. >>>>> >>>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Jenkins Developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/jenkinsci-dev/ce11e102-2a63-4d48-8e59-3ebc22a171d5%40googlegroups.com >>>> >>>> <https://groups.google.com/d/msgid/jenkinsci-dev/ce11e102-2a63-4d48-8e59-3ebc22a171d5%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/e89aa24c-f140-49ce-94f1-76c8f3a25ad3%40googlegroups.com >> >> <https://groups.google.com/d/msgid/jenkinsci-dev/e89aa24c-f140-49ce-94f1-76c8f3a25ad3%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/e5178247-dd66-4ead-9ce7-ab675981d594%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
