I've added you as a committer. Sorry for the delay. Sounds like a reasonable effort has been spent on contacting the original author, so from my PoV you should just proceed and merge, especially if you have KostyaSha's +1 on the change itself.
2015-06-08 5:20 GMT-07:00 The Thief <[email protected]>: > Hello everyone, > > 10 more days passed since my initial email so I decided to write another > one with details of what I'm trying to achieve. > > saml-plugin, as it stated at plugin's description page > <https://wiki.jenkins-ci.org/display/JENKINS/SAML+Plugin>, provide > ability to authenticate users to Jenkins using SAML SSO protocol. On that > page there is a discussion in the comments about lack of groups support. > Lack of this feature makes it impossible to use this plugin together with > Role-Based > Strategy to configure security on per-group basis, only per-user level > security is supported. So, in order to address this issue I've added > groups support and made this > <https://github.com/jenkinsci/saml-plugin/pull/1> pull request. As nobody > answered me in a week, I asked for commit rights (according to this > document > <https://wiki.jenkins-ci.org/display/JENKINS/Pull+Request+to+Repositories> > ) > My account is https://github.com/0xcfff > You can also make me a maintainer. I don't have much knowledge in Jenkins > codebase but I could try to assist if something related to this plugin > breaks one day. Also I can try to add tests and one more feature to this > plugin when I have time. > > On Fri, May 29, 2015 at 1:06 AM, The Thief <[email protected]> wrote: > >> Could you please provide me with commit access to saml-plugin repository, >> github account https://github.com/0xcfff. I've made a pull request about >> a week ago but it still has not been merged. >> > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAGLo7iuJCbihgYB1wCeRKdfKBHndanZKK5AxQ%3D%2BX5F%3DQYNqptg%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CAGLo7iuJCbihgYB1wCeRKdfKBHndanZKK5AxQ%3D%2BX5F%3DQYNqptg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- Kohsuke Kawaguchi -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAN4CQ4zssjFu%2BT189OVw2HCz3R6pGv0GB25BkaZAoLT_HMfwNQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
