+1 with Daniel & Oleg. For a concrete example, I recently processed a PR [1] after it lingered for 12 days (it already happened to stay a bit longer), answered and asked for some rework because I disagreed with the implementation. After some times, I just closed "politely" the PR.
With this policy, the contributor could have been granted access and even could have made a release of the plugin. Though I deeply support the open policy of the Jenkins project, I'm not totally sure in this case it wouldn't appear as somehow disrespectful to the current maintainers of active projects and their past work (don't get me wrong here, I'm trying to be balanced). Cheers [1] https://github.com/jenkinsci/buildtriggerbadge-plugin/pull/13 2015-06-08 22:27 GMT+02:00 Daniel Beck <[email protected]>: > > On 08.06.2015, at 20:07, Kohsuke Kawaguchi <[email protected]> wrote: > > > As a rule of thumb, I'd like to reduce us blocking people who are > interested in contributing, so we should grant the commit access in > parallel to suggesting to talk to the current maintainer. > > I disagree as well. There's a huge difference between admitting a new > plugin into the jenkinsci org, and adding new developers/maintainers to an > existing plugin. > > This policy will only make existing maintainers quit when they come back > from a two week vacation and their plugin is completely broken by a new > developer who wasn't as familiar with it as he thought, and asked for > commit access instead of opening a PR. > > If the plugin is actively maintained, we should ask new contributors to > open PRs instead of immediately granting commit access. _That_ should be > our rule of thumb. > > (Not relevant to this plugin of course, as we have confirmation that the > existing maintainer is okay with handing over ownership, but it needed to > be mentioned.) > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/5B26B418-0412-406D-9661-D61BE3379942%40beckweb.net > . > For more options, visit https://groups.google.com/d/optout. > -- Baptiste <Batmat> MATHUS - http://batmat.net Sauvez un arbre, Mangez un castor ! -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS5irYmKnMEujuqFOihmqdXp9htksSvhBoTL6UCOO2jjwQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
