I've added some comments to the pull request. In general I'm OK with granting permissions, but it would be better if you request reviews for changes you make in order to get some advices from other Jenkins developers.
среда, 15 июля 2015 г., 12:03:57 UTC+3 пользователь Deniz Bahadir написал: > > Hi everybody, > > 2 weeks ago I provided an extension for the Version-Number Plugin. [1,2] > Since then I did not get any reaction. So, I am now following the > recommended procedures [3] and ask for someone to review my pull-request. > > Especially, I am curious if it could somehow get improved by using the > Token Macro Plugin. (However, I would prefer to use the current > implementation, first.) > > Nevertheless, I wanted to ask for commit-access, too. (Github-user: > "Bagira80"; repository-access to: [4]) > > Thank you, > Deniz Bahadir > > [1] https://issues.jenkins-ci.org/browse/JENKINS-29134 > [2] https://github.com/jenkinsci/versionnumber-plugin/pull/7 > [3] > https://wiki.jenkins-ci.org/display/JENKINS/Pull+Request+to+Repositories > [4] https://github.com/jenkinsci/versionnumber-plugin > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/21921804-a02b-4f59-a3ce-bfdd7a74c86d%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
