good guess. this is definitely not good news for ad-facies discrimination :-)
On Thu, Jul 16, 2015 at 4:59 PM, Daniel Beck <[email protected]> wrote: > Forgot a return in the 'if' block? > > On 16.07.2015, at 16:51, Ivo Bellin Salarin <[email protected]> > wrote: > >> Hi all, >> >> My PM asked to replace the jenkins favicon with a different one, >> respecting the corporate chart. (IMHO, because he doesn't like >> moustaches) >> Well, apart from the discutable reasons of this choice, I'm obliged to >> do that, unless it's technically unfeasible. >> >> I've tried with a PluginServletFilter (you can find its code on this >> gist -- https://gist.github.com/nilleb/e511166b90d65038bcd3). >> >> But each time the favicon is served, in the jenkins logs I find a trace like: >> >> juil. 16, 2015 4:38:23 PM AVERTISSEMENT >> org.eclipse.jetty.util.log.JavaUtilLog warn >> >> Ignoring extra content 00 ¨%F ¨ î% ˆ –6 (binary content follows) >> >> Do you think that the pluginServletFilter above is doing something >> wrong? Should proceed somehow differently? Or, replacing the jenkins >> favicon is simply not feasible? >> >> Thanks in advance, >> Ivo >> -- >> http://www.nilleb.com >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CAPc4eF_d3pKQ8fG3mUG_q2gYzQ8O%3Dei%3DtF%2BJkKhq6F06FskFnA%40mail.gmail.com. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/823D8514-280E-4463-964D-287BA5F4424E%40beckweb.net. > For more options, visit https://groups.google.com/d/optout. -- http://www.nilleb.com -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPc4eF9LENyKbcHM8QORNB4X974jdQRorKEgBvN2iPzfYc-BmA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
