Oleg is being polite when he says that there may be a slight response delay due to many activities on the git plugin.
There are typically very long delays to requests to modify the git plugin and the git client plugin. I'm quite conservative about accepting changes into the plugin. It has many different active use cases among the 60 000+ installations and many ways that a seemingly straightforward change can break someone's high value use case. Thanks, Mark Waite On Thu, Jul 30, 2015 at 2:54 AM Oleg Nenashev <[email protected]> wrote: > Hi Hillebrand, > > I've added several comments to your pull request. I would not vote for > merging it in the current state. > > BTW you can always ping the plugin maintainers if you feel the pull > request hangs. Mark performs the most of maintenance work for Git plugin > (which is one of the most hottest ones), so there may be slight response > delays due to many activities. > > Best regards, > Oleg > > четверг, 30 июля 2015 г., 10:15:35 UTC+3 пользователь > [email protected] написал: > >> Hi all, >> >> I made some minor modifications to the merge before build feature of the >> git-plugin to merge from another branch into the current and push the merge >> result to the current branch after the build is completed. I created a pull >> request <https://github.com/jenkinsci/git-plugin/pull/332> on june 25th, >> but it has been quite since. >> >> It is not a major change and it has good test coverage, so i think it can >> be merged in absence of a review. Can i get commit access to the git-plugin >> repository? My GitHub accountname is hillebrand. >> >> >> >> Regards >> , >> >> >> >> Hillebrand Gelderblom >> > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFFjvuFvwAUm_SGTka52XFndmhBEKw-iVNvAb8vE4On9Q%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
