Hey Mark, I added two tests to a branch on my fork <https://github.com/praqma-thi/git-client-plugin/tree/repoDefaults>, which also contains my changes for adding --no-comit. One fails for the JGit implementation, while the other fails for the CLI implementaion. Yesterday's post was way too big, by the way, the whole thing just boils down to: The current JGit implementation always overrides repository defaults, even when options weren't explicitly set. The current CLI implementation sometimes doesn't override repository defaults, even when options were explicitly set.
So everything works fine, but things get a bit confusing once you start changing the repo defaults. We'd have to keep track of which options the user actually set in the command builder and *only* add those. To imagine this all started with "Should I call this method setCommit or setNoCommit?".. :) Kind regards, Thierry -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/d44b4c98-443a-4fde-ad48-acaae2fa721e%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
