On Fri, Sep 18, 2015 at 8:08 AM Jesse Glick <[email protected]> wrote:
> On Thu, Sep 17, 2015 at 2:58 PM, Romain SOMMERARD <[email protected]> > wrote: > > If we write a test which describe a bug, is it good to make a pull > request > > for this test without fix ? > > IMO yes please: the most important contribution to a bug fix is the test. > I agree with Jesse. The test is the most critical part (for me) in considering a proposed fix. If the test shows that the submitter understood the conditions which cause the bug, I'm much more willing to believe they understood the risks of the fix. Mark Waite -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFxVCbV%3DOYedR5hGveJe8vziAi36fOMPbwBYW5Gawp1fw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
