Hi Patrick, Apologies for missing the request. If there is no response to the thread within one week, please ping again in order to move the thread to the top. It's also a recommended practice to CC plugin owners when you create such e-mails. Active users usually filter away notifications and finally miss them.
I've added Seiji to Cc. He seems to be active in this plugin, hence we cannot just grant permissions. BTW, the code looks mostly good to me. Best regards, Oleg Nenashev вторник, 29 сентября 2015 г., 21:15:09 UTC+3 пользователь Patrick C. Brückner написал: > > Another month has gone by, and neither ssogabe has responded to my pull > requests nor have I received an answer on this. > > Anyone ? > > Am Montag, 31. August 2015 19:15:18 UTC+2 schrieb Patrick C. Brückner: >> >> Hi, >> >> I have been a very happy Jenkins user for some time, and this summer I >> came across some medium issues in the cloverphp plugin. >> >> These have had open issues, one of the two was open for almost two years. >> I have created two pull requests, but the main developer (ssogabe) is not >> responding and he also seems inactive when looking at his GitHub activity >> chart. >> >> https://issues.jenkins-ci.org/browse/JENKINS-26722 -> >> https://github.com/jenkinsci/cloverphp-plugin/pull/4 >> https://issues.jenkins-ci.org/browse/JENKINS-20233 -> >> https://github.com/jenkinsci/cloverphp-plugin/pull/5 >> >> As my company has been using the patched version for a week and I have >> added unit tests for the changes made, I am quite confident about these >> changes. >> >> I am looking into some of the other open issues, but before I start >> developing, I want to make sure that my changes have a chance to make it >> upstream. >> >> Can someone please verify them and either give me commit access or merge >> my changes? >> >> For the quality of software! Long live Mr. Jenkins! >> > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/9cf90053-b836-443a-9ced-cdf7e6fce7a7%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
