Hi Vimil, If you create a thread about a plugin, please provide the background and CC plugin maintainers. Otherwise the thread may confuse people.
Background (my vision)... - Vimil has already created a patch for it: https://github.com/jenkinsci/promoted-builds-plugin/pull/58 - This patch has been merged into the master branch without waiting for review - When Damien Nozay transferred the ownership to me, I've reviewed the master branch and discovered this patch - In the patch I've discovered there were serious issues IMHO - Since the patch has not been released yet & has not been reviewed by anyone, I decided to revert it - I proposed to update the implementation according to comments and to create a new PR - After a short discussion, Vimil dissapeared I'd be happy to continue the discussion of this improvement. If I understand correctly, the ball is on your side. Best regards, Oleg Nenashev вторник, 6 октября 2015 г., 7:37:04 UTC+3 пользователь vimil написал: > > Hi, > > Currently the promoted builds plugin allows you to configure the promotion > icon in the configuration section of the promotion process. > > However once configured, it cannot be modified programmatically by a > groovy promotion build step for a specific promotion. This is because the > promotion icon is stored at the promotion process level instead of the > promotion level. > > I would like to enhance the promoted builds plugin so as to store the > promotion icon at the promotion level and expose a method in the promotion > class to change the icon. This way I can add a groovy step to the promotion > process that can change the icon programmatically for that specific > promotion without affecting other promotions. > > Let me know if there are any objections to this enhancement, otherwise I > can provide a patch for this. > > Thanks > Vimil > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/feb01a92-8525-4f67-887e-823777f2b8af%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
