Yes, it's totally cool that you did this plugin. I don't meant to imply that you shouldn't have done that. Quite the opposite.
I've added this for 1.633. 2015-10-08 11:41 GMT-07:00 Sunil Patel <[email protected]>: > No reason for it not to be in the core, I'd love for that to happen! > And that's right, nothing more than the <link>. > > I just made the plugin so I could start using the icon at work straight > away and thought I may as well share it :) > > sunil. > > On 8 October 2015 at 19:03, Kohsuke Kawaguchi <[email protected]> wrote: > >> Thanks, this is cool. >> >> Any reason this shouldn't be a part of the core? I'd love to integrate it >> in there. It's just adding a <link> tag, right? >> >> 2015-10-08 10:56 GMT-07:00 Sunil Patel <[email protected]>: >> >>> Hello! >>> >>> Safari 9.0 introduced the ability to pin tabs. The icons for these must >>> be a solid black svg (and as such the favicon can't be used). >>> >>> If you want to add the icon to your jenkins, my super tiny plug-in to do >>> that is here: >>> https://github.com/srpatel/jenkins-pinned-tab >>> >>> (jenkins-ci username = archduke) >>> >>> Thanks >>> sunil. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/9ad26658-4f81-4f0a-a613-af03135e4a11%40googlegroups.com >>> <https://groups.google.com/d/msgid/jenkinsci-dev/9ad26658-4f81-4f0a-a613-af03135e4a11%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> Kohsuke Kawaguchi >> >> -- >> You received this message because you are subscribed to a topic in the >> Google Groups "Jenkins Developers" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/jenkinsci-dev/W29LIfo2uME/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CAN4CQ4zg4m4c29Y8HQbhxxQh9AZSfnBNOqPQrpxS4hJgSML99w%40mail.gmail.com >> <https://groups.google.com/d/msgid/jenkinsci-dev/CAN4CQ4zg4m4c29Y8HQbhxxQh9AZSfnBNOqPQrpxS4hJgSML99w%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAONyboSenJev7zbJQ6eGn6k-9zG9HaFyMSYpsEZbJmZDfwGiJQ%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CAONyboSenJev7zbJQ6eGn6k-9zG9HaFyMSYpsEZbJmZDfwGiJQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- Kohsuke Kawaguchi -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAN4CQ4y_1zKVgnjJTCD8e2opkSiVJ%3DkzxPSbZUoZJoCVpV1V5Q%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
